mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@hack.frob.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Amerigo Wang <amwang@redhat.com>,
	"Jonathan M. Foote" <jmfoote@cert.org>,
	Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH -mm v2 2/2] coredump: add a new elf note with siginfo of the signal
Date: Tue, 18 Sep 2012 09:41:03 -0700 (PDT)	[thread overview]
Message-ID: <20120918164103.440C22C0A4@topped-with-meat.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Tuesday, 18 September 2012 17:30:27 +0200 <20120918153027.GA21612@redhat.com>

> But, somehow I forgot about compat tasks when we discussed this before.
> Perhaps the code above should do
> 
> 	if (is_compat_task())
> 		copy_siginfo_to_user32(...);
> 	else
> 		copy_siginfo_to_user(...);
> 
> ?

compat_binfmt_elf.c will define a separate copy of this code via #include.
So it just needs #define copy_siginfo_to_user copy_siginfo_to_user32 or
something like that, as the various other types and functions are handled.


Thanks,
Roland

  reply	other threads:[~2012-09-18 16:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 14:53 [PATCH -mm v2 0/2] " Denys Vlasenko
2012-09-18 14:53 ` [PATCH -mm v2 1/2] coredump: pass siginfo_t* to do_coredump() and below, not merely signr Denys Vlasenko
2012-09-18 14:53 ` [PATCH -mm v2 2/2] coredump: add a new elf note with siginfo of the signal Denys Vlasenko
2012-09-18 15:30   ` Oleg Nesterov
2012-09-18 16:41     ` Roland McGrath [this message]
2012-09-18 16:57       ` Oleg Nesterov
2012-09-19 16:06       ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918164103.440C22C0A4@topped-with-meat.com \
    --to=roland@hack.frob.com \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=jmfoote@cert.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=palves@redhat.com \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®