From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: sjur.brandeland@stericsson.com
Cc: "Ohad Ben-Cohen" <ohad@wizery.com>,
"Sjur Brændeland" <sjurbren@gmail.com>,
linux-kernel@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [RFCv2] remoteproc: Add STE modem driver for remoteproc
Date: Tue, 18 Sep 2012 19:48:19 +0100 [thread overview]
Message-ID: <20120918194819.08538bed@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1347992952-4134-1-git-send-email-sjur.brandeland@stericsson.com>
O> + /* make sure the offsets array isn't truncated */
> + if (table->num * sizeof(table->offset[0]) +
> + sizeof(struct resource_table) > entry->size) {
> + sproc_err(sproc, "resource table incomplete\n");
> + return NULL;
None of these checks appear to be robust against maths overflow. So the
question I'd ask is how far do you trust your inputs ?
Alan
next prev parent reply other threads:[~2012-09-18 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 18:29 sjur.brandeland
2012-09-18 18:48 ` Alan Cox [this message]
2012-09-18 19:09 ` Sjur Brændeland
2012-09-19 9:09 ` Ohad Ben-Cohen
2012-09-19 10:08 ` Sjur BRENDELAND
2012-09-19 14:29 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918194819.08538bed@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sjur.brandeland@stericsson.com \
--cc=sjurbren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®