From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Feng Tang <feng.tang@intel.com>
Cc: mingo@elte.hu, a.p.zijlstra@chello.nl, andi@firstfloor.org,
namhyung@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] perf tool: Add a global variable "const char *input_name"
Date: Thu, 20 Sep 2012 12:05:51 -0300 [thread overview]
Message-ID: <20120920150551.GD26278@infradead.org> (raw)
In-Reply-To: <1348150779-17707-1-git-send-email-feng.tang@intel.com>
Em Thu, Sep 20, 2012 at 10:19:39PM +0800, Feng Tang escreveu:
> Currently many perf ommands annotate/evlist/report/script/lock etc
> all support "-i" option to chose a specific perf data, and all
> of them create a local "input_name" to save the file name for
> that perf data.
>
> So adding a global variable could unify all those local ones, and
> it will also be useful for other codes which need to know the file name.
But I think the input_name should be passed as a parameter to whoever
needs it. Think about 'perf diff', for instance, it deals with two
perf.data files.
In general I think we should _remove_ more globals :-)
- Arnaldo
next prev parent reply other threads:[~2012-09-20 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 14:19 Feng Tang
2012-09-20 15:05 ` Arnaldo Carvalho de Melo [this message]
2012-09-20 15:32 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920150551.GD26278@infradead.org \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®