From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757602Ab2IUSsQ (ORCPT ); Fri, 21 Sep 2012 14:48:16 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:37701 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757439Ab2IUSsN (ORCPT ); Fri, 21 Sep 2012 14:48:13 -0400 Date: Fri, 21 Sep 2012 19:47:21 +0100 From: Russell King - ARM Linux To: "S, Venkatraman" Cc: Matt Porter , Tony Lindgren , Sekhar Nori , Grant Likely , Mark Brown , Benoit Cousson , Vinod Koul , Rob Landley , Chris Ball , Linux DaVinci Kernel List , Arnd Bergmann , Linux Documentation List , Devicetree Discuss , Linux MMC List , Linux Kernel Mailing List , Rob Herring , Dan Williams , Linux SPI Devel List , Linux OMAP List , Linux ARM Kernel List Subject: Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC Message-ID: <20120921184721.GD31374@n2100.arm.linux.org.uk> References: <1348152226-13588-1-git-send-email-mporter@ti.com> <1348152226-13588-9-git-send-email-mporter@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 21, 2012 at 10:45:29PM +0530, S, Venkatraman wrote: > On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: > > The EDMA DMAC has a hardware limitation that prevents supporting > > scatter gather lists with any number of segments. Since the EDMA > > DMA Engine driver sets the maximum segments to 16, we do the > > same. > > > > Note: this can be removed once the DMA Engine API supports an > > API to query the DMAC's segment limitations. > > > > I wouldn't want to bind the properties of EDMA to omap_hsmmc as this patch > suggests. Why don't we have a max_segs property, which when explicitly specified > in DT, will override the default ? Why not have a generic way that DMA engine can export these kinds of properties?