From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986Ab2IVKGg (ORCPT ); Sat, 22 Sep 2012 06:06:36 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:37981 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754458Ab2IVKGf (ORCPT ); Sat, 22 Sep 2012 06:06:35 -0400 Date: Sat, 22 Sep 2012 11:06:05 +0100 From: Russell King - ARM Linux To: Stephen Boyd Cc: Mike Turquette , Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] Introduce devm_clk_register() Message-ID: <20120922100604.GI15609@n2100.arm.linux.org.uk> References: <1348034730-16473-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1348034730-16473-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2012 at 11:05:27PM -0700, Stephen Boyd wrote: > The first patch in this series fixes error checking in the wm831x clock > driver and is here to prevent context conflicts in the third patch. > I split it out in case it needed to merge sooner rather than later. > > The goal of this series is to add devm_clk_register() so I can use it in > some MSM clock code I'm sending out in the near future. The second > patch adds the API and the third patch moves over an existing user of > clk_unregister() to the devm API. Can we guarantee that the clocks are unused when the module is removed? If we can't make that guarantee, then devm_* should not be used here, and instead there should be refcounting done in the clocks (that's what the __clk_get() and __clk_put() hooks are there for.)