From: Andrew Lunn <andrew@lunn.ch>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: dove: Remove watchdog from DT
Date: Tue, 25 Sep 2012 07:35:42 +0200 [thread overview]
Message-ID: <20120925053542.GK14266@lunn.ch> (raw)
In-Reply-To: <1348531338-16624-6-git-send-email-sebastian.hesselbarth@gmail.com>
On Tue, Sep 25, 2012 at 02:02:17AM +0200, Sebastian Hesselbarth wrote:
> The watchdog on dove requires an interrupt that is not yet
> available on DT. Therefore, the watchdog DT node is removed
> until the corresponding chained intc is available.
Hi Sebastian
Just for my understanding: Is the problem here:
/* Clear watchdog timer interrupt */
reg = readl(BRIDGE_CAUSE);
reg &= ~WDT_INT_REQ;
writel(reg, BRIDGE_CAUSE);
I ask, because there is no need to pass an interrupt in the DT node.
It is clear to me that bit of code above needs cleaning up sometime
soon.
Thanks
Andrew
next prev parent reply other threads:[~2012-09-25 5:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 0:02 [PATCH 0/6] Dove fixes for arm-soc/for-next Sebastian Hesselbarth
2012-09-25 0:02 ` [PATCH 1/6] ARM: dove: Add pcie clock support Sebastian Hesselbarth
2012-09-25 0:02 ` [PATCH 2/6] ARM: dove: Fix tauros2 device tree init Sebastian Hesselbarth
2012-09-25 1:22 ` Sebastian Hesselbarth
2012-09-25 5:19 ` Andrew Lunn
2012-09-25 8:56 ` Sebastian Hesselbarth
2012-09-25 0:02 ` [PATCH 3/6] ARM: dove: Fix clock names of sata and gbe Sebastian Hesselbarth
2012-09-25 0:02 ` [PATCH 4/6] ARM: dove: Restructure SoC device tree descriptor Sebastian Hesselbarth
2012-09-25 0:02 ` [PATCH 5/6] ARM: dove: Remove watchdog from DT Sebastian Hesselbarth
2012-09-25 5:35 ` Andrew Lunn [this message]
2012-09-25 9:11 ` Sebastian Hesselbarth
2012-09-25 9:18 ` Thomas Petazzoni
2012-09-25 9:46 ` Andrew Lunn
2012-09-25 10:14 ` Thomas Petazzoni
2012-09-25 10:31 ` Andrew Lunn
2012-09-25 11:20 ` Arnd Bergmann
2012-09-25 11:48 ` Arnaud Patard
2012-09-25 12:28 ` Arnd Bergmann
2012-09-25 12:33 ` Arnd Bergmann
[not found] ` <CABLWKA9NjX0+cQZGBOGus99fFkcpwjPxnhmsBuZBz50VbxXyvw@mail.gmail.com>
2012-09-25 20:02 ` Arnd Bergmann
2012-09-25 0:02 ` [PATCH 6/6] ARM: dove: Add crypto engine to DT Sebastian Hesselbarth
2012-09-25 5:37 ` [PATCH 0/6] Dove fixes for arm-soc/for-next Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925053542.GK14266@lunn.ch \
--to=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®