From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755791Ab2IYLy4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Sep 2012 07:54:56 -0400
Received: from ams-iport-1.cisco.com ([144.254.224.140]:19123 "EHLO
	ams-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755054Ab2IYLyy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Sep 2012 07:54:54 -0400
X-IronPort-AV: E=Sophos;i="4.80,481,1344211200"; 
   d="scan'208";a="144331350"
From: Hans Verkuil <hansverk@cisco.com>
Organization: Cisco Systems Norway
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] media: davinci: vpif: set device capabilities
Date: Tue, 25 Sep 2012 13:54:29 +0200
User-Agent: KMail/1.13.7 (Linux/3.5-0.slh.1-aptosid-amd64; KDE/4.8.4; x86_64; ; )
Cc: Prabhakar <prabhakar.csengg@gmail.com>, LMML <linux-media@vger.kernel.org>,
        DLOS <davinci-linux-open-source@linux.davincidsp.com>,
        Manjunath Hadli <manjunath.hadli@ti.com>,
        Mauro Carvalho Chehab <mchehab@infradead.org>,
        VGER <linux-kernel@vger.kernel.org>,
        "Lad, Prabhakar" <prabhakar.lad@ti.com>,
        Hans Verkuil <hans.verkuil@cisco.com>
References: <1348571784-4237-1-git-send-email-prabhakar.lad@ti.com> <201209251343.36240.hansverk@cisco.com> <2015356.T8yoHfqqkq@avalon>
In-Reply-To: <2015356.T8yoHfqqkq@avalon>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201209251354.29824.hansverk@cisco.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue 25 September 2012 13:49:16 Laurent Pinchart wrote:
> Hi Hans,
> 
> On Tuesday 25 September 2012 13:43:36 Hans Verkuil wrote:
> > On Tue 25 September 2012 13:16:24 Prabhakar wrote:
> > > From: Lad, Prabhakar <prabhakar.lad@ti.com>
> > > 
> > > Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> > > Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > ---
> > > 
> > >  drivers/media/platform/davinci/vpif_capture.c |    4 +++-
> > >  drivers/media/platform/davinci/vpif_display.c |    4 +++-
> > >  2 files changed, 6 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/media/platform/davinci/vpif_capture.c
> > > b/drivers/media/platform/davinci/vpif_capture.c index 4828888..faeca98
> > > 100644
> > > --- a/drivers/media/platform/davinci/vpif_capture.c
> > > +++ b/drivers/media/platform/davinci/vpif_capture.c
> > > @@ -1630,7 +1630,9 @@ static int vpif_querycap(struct file *file, void 
> > > *priv,> 
> > >  {
> > >  
> > >  	struct vpif_capture_config *config = vpif_dev->platform_data;
> > > 
> > > -	cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
> > > +	cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING |
> > > +			V4L2_CAP_READWRITE;
> > > +	cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
> > > 
> > >  	strlcpy(cap->driver, "vpif capture", sizeof(cap->driver));
> > 
> > This should be the real driver name which is 'vpif_capture'.
> > 
> > >  	strlcpy(cap->bus_info, "VPIF Platform", sizeof(cap->bus_info));
> > 
> > For bus_info I would use: "platform:vpif_capture".
> > 
> > The 'platform:' prefix is going to be the standard for platform drivers.
> 
> What about
> 
> snprintf(cap->driver, sizeof(cap->driver), "platform:%s", dev_name(vpif_dev));
> 
> That would handle cases where multiple platform devices of the same type are 
> present.

Sure, that's even better. You do have to check that this gives you what you'd
expect (i.e., that you don't end up with "platform:platform:vpif_capture").

Regards,

	Hans