From: Wim Van Sebroeck <wim@iguana.be>
To: Oskar Schirmer <oskar@scara.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfram Sang <w.sang@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v3] watchdog/imx2+: add support for pretimeout interrupt functionality
Date: Thu, 27 Sep 2012 23:24:44 +0200 [thread overview]
Message-ID: <20120927212444.GK16482@spo001.leaseweb.com> (raw)
In-Reply-To: <20120927130837.GA22448@curry>
Hi Oskar,
> unless there is another issue with this patch,
> could You give an ack now?
>
> thanks,
> Oskar
>
> On Thu, Sep 20, 2012 at 15:37:24 +0000, Oskar Schirmer wrote:
> > This watchdog device provides pretimeout facilities:
> > Set some timeout value and get informed about imminent
> > watchdog activity thru interrupt.
> >
> > Allow user to wait for this asynchronous event thru poll(2),
> > and to clear it implicitely upon dog appeasement.
> >
> > There is only one precedent in current kernel that implements
> > watchdog pretimeout, ipmi_watchdog. It provides pretimeout
> > event thru poll, and requires a read(2) call to clear it.
> >
> > However, as write(2) does calm the dog and so wind up the
> > timer anyway, it is obvious to let poll(2) state writability
> > where pretimeout has passed.
> [...]
No, I'm not givinbg this an ACK nor a NAK at this moment.
I will review best options after the next merge window.
Kind regards,
Wim.
prev parent reply other threads:[~2012-09-27 21:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 10:37 [PATCH] " Oskar Schirmer
2012-07-03 9:10 ` [PATCH] watchdog/imx2+: add support for pretimeout interrupt Oskar Schirmer
2012-09-05 7:23 ` Oskar Schirmer
2012-09-11 10:00 ` [PATCH v2] watchdog/imx2+: add support for pretimeout interrupt functionality Oskar Schirmer
2012-09-11 11:00 ` Wim Van Sebroeck
2012-09-11 13:39 ` Oskar Schirmer
2012-09-20 15:37 ` [PATCH v3] " Oskar Schirmer
2012-09-27 13:08 ` Oskar Schirmer
2012-09-27 21:24 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927212444.GK16482@spo001.leaseweb.com \
--to=wim@iguana.be \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=oskar@scara.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®