From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757519Ab2I1Kv3 (ORCPT ); Fri, 28 Sep 2012 06:51:29 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:56983 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757271Ab2I1Kv1 (ORCPT ); Fri, 28 Sep 2012 06:51:27 -0400 Date: Fri, 28 Sep 2012 12:51:13 +0200 From: Thierry Reding To: Mel Gorman Cc: Peter Ujfalusi , Minchan Kim , Andrew Morton , Marek Szyprowski , Michal Nazarewicz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Bartlomiej Zolnierkiewicz , Kyungmin Park , Mark Brown Subject: Re: CMA broken in next-20120926 Message-ID: <20120928105113.GA18883@avionic-0098.mockup.avionic-design.de> References: <20120927112911.GA25959@avionic-0098.mockup.avionic-design.de> <20120927151159.4427fc8f.akpm@linux-foundation.org> <20120928054330.GA27594@bbox> <20120928083722.GM3429@suse.de> <50656459.70309@ti.com> <20120928102728.GN3429@suse.de> <20120928103207.GA22811@avionic-0098.mockup.avionic-design.de> <20120928103815.GA15219@avionic-0098.mockup.avionic-design.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <20120928103815.GA15219@avionic-0098.mockup.avionic-design.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Provags-ID: V02:K0:bkS0CaZGl5UT7asMDb7TSHKB03ZMG0TYZgQrnNA85W3 QI1txWtJNoEOLSRxOWLo3uqHd+72HzypvQ2RfBg3/a4j/8zwG8 wZyUr30aloOojtOmXGI2U4yra/XdNRj/74O0ZIr94eSPgJE4jk G/W/18DuxaXtdkZeUw9WsEHhdyMUZHXw5eT/kR/1hghOXvY3sm /1ZE5Kty7pAS1vZkcncP1BBvO5+Lq1C7EfaIgbZmT8+vcSbeXY d6d5DF+L6FhP+PeNiASjTKUJZ5rc6VqIgJk9n+SRzwtjGunFWm QPETDlAT+csPQKDauoNmcl7edtHzQj5UacT3+HJqd3uaM2wEOT prmRBcppLxSB5C210qB1Zd1PfFv+UJVUTHIiMkUbO9scESrZWQ hGjcQaoJ2NuZ66p+tXF0idhfVmCdSs13SW6CkFpblIybADO/Js PNIVJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 28, 2012 at 12:38:15PM +0200, Thierry Reding wrote: > On Fri, Sep 28, 2012 at 12:32:07PM +0200, Thierry Reding wrote: > > On Fri, Sep 28, 2012 at 11:27:28AM +0100, Mel Gorman wrote: > > > On Fri, Sep 28, 2012 at 11:48:25AM +0300, Peter Ujfalusi wrote: > > > > Hi, > > > >=20 > > > > On 09/28/2012 11:37 AM, Mel Gorman wrote: > > > > >> I hope this patch fixes the bug. If this patch fixes the problem > > > > >> but has some problem about description or someone has better ide= a, > > > > >> feel free to modify and resend to akpm, Please. > > > > >> > > > > >=20 > > > > > A full revert is overkill. Can the following patch be tested as a > > > > > potential replacement please? > > > > >=20 > > > > > ---8<--- > > > > > mm: compaction: Iron out isolate_freepages_block() and isolate_fr= eepages_range() -fix1 > > > > >=20 > > > > > CMA is reported to be broken in next-20120926. Minchan Kim pointe= d out > > > > > that this was due to nr_scanned !=3D total_isolated in the case o= f CMA > > > > > because PageBuddy pages are one scan but many isolations in CMA. = This > > > > > patch should address the problem. > > > > >=20 > > > > > This patch is a fix for > > > > > mm-compaction-acquire-the-zone-lock-as-late-as-possible-fix-2.pat= ch > > > > >=20 > > > > > Signed-off-by: Mel Gorman > > > >=20 > > > > linux-next + this patch alone also works for me. > > > >=20 > > > > Tested-by: Peter Ujfalusi > > >=20 > > > Thanks Peter. I expect it also works for Thierry as I expect you were > > > suffering the same problem but obviously confirmation of that would b= e nice. > >=20 > > I've been running a few tests and indeed this solves the obvious problem > > that the coherent pool cannot be created at boot (which in turn caused > > the ethernet adapter to fail on Tegra). > >=20 > > However I've been working on the Tegra DRM driver, which uses CMA to > > allocate large chunks of framebuffer memory and these are now failing. > > I'll need to check if Minchan's patch solves that problem as well. >=20 > Indeed, with Minchan's patch the DRM can allocate the framebuffer > without a problem. Something else must be wrong then. However, depending on the size of the allocation it also happens with Minchan's patch. What I see is this: [ 60.736729] alloc_contig_range test_pages_isolated(1e900, 1f0e9) failed [ 60.743572] alloc_contig_range test_pages_isolated(1ea00, 1f1e9) failed [ 60.750424] alloc_contig_range test_pages_isolated(1ea00, 1f2e9) failed [ 60.757239] alloc_contig_range test_pages_isolated(1ec00, 1f3e9) failed [ 60.764066] alloc_contig_range test_pages_isolated(1ec00, 1f4e9) failed [ 60.770893] alloc_contig_range test_pages_isolated(1ec00, 1f5e9) failed [ 60.777698] alloc_contig_range test_pages_isolated(1ec00, 1f6e9) failed [ 60.784526] alloc_contig_range test_pages_isolated(1f000, 1f7e9) failed [ 60.791148] drm tegra: Failed to alloc buffer: 8294400 I'm pretty sure this did work before next-20120926. Thierry --T4sUOijqQbZv57TR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQZYEhAAoJEN0jrNd/PrOhkioP/idDx/MA9xrd9IkshuS06B7c 3mW7ZrZmHdVxQjTGzINoqwyh/rzvGBEATB+DMG2BHTfaASHWzDrVflutLeHB9z2C bqF0tBO2ori8IXmCl3QMYwEzFfSn5afv9lD4sPwzsHVWFQslhtgeFXuPAvNONiCc 4G4OixoEMRQ1SqHKn4aJPrhLxV8/yBg6vnmZgqFJNRrKibYGi1uq1ktPEO3KSC40 nKykMb+U9ZQJkTK3JlTkrevLjypozxFrr/IFVihufDPzHKN/ynTdnXDxROmFlXri grHFPvY+7oQcwDTompJblVcyKg27wXLlmkXYiw4MuM+ENLRhsiwV3gZUu2KRckQS NhLSI6jDdOgO2Ax+zgV/glakeOtnmDWSMNqZYChZT2aOpRxUzFmdheRiaUEdUpCJ T+5TbpSER2zKlkjSGgWbAt6xmoLYDOaBAAg40jNyfYsL0fg5k2dSsya20skEpVTz DgNWo9e4TDkDaSZkkzVYoXYX0+fZL/1+bKIwfoi/QrX2wzRHKqwYk+Cl/c1t18Nz L0/4eimBxPyVnd19QzykSaejvQesOg3HBcmzHijoRxoQvTUDNIoxazvrlz76T5SA qdPSvev47NoZ1vlPd8PdVns8TcmeuEuk0apDIIzBzCsLwiNuMfE/1r1zXvwjwPSc 8IYrDaDk9arP2GjIgLaG =PCVb -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--