From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Dave Jones <davej@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Myklebust, Trond" <Trond.Myklebust@netapp.com>,
Joerg Roedel <joro@8bytes.org>,
Joerg Roedel <joerg.roedel@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: BUG_ON/panic proliferation.
Date: Fri, 28 Sep 2012 11:08:29 +0100 [thread overview]
Message-ID: <20120928110829.5ab03cfe@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <5064F4E2.6010301@gmail.com>
> Remove panic calls from drivers/tty/pty.c
>
> There is no need to panic the system if the allocation/registration of
> the pty drivers fails. Instead return an error and fail the module load.
>
> Signed-off-by: Ryan Mallon <rmallon@gmail.com>
NAK
this is pointless complexity
This is early boot up code. If it fails we ran out of memory before even
the base drivers got running. It's already game over.
next prev parent reply other threads:[~2012-09-28 10:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 13:41 kernel BUG at /data/lemmy/linux.trees.git/fs/nfs/idmap.c:681! Joerg Roedel
2012-08-07 13:55 ` Bryan Schumaker
2012-08-07 14:15 ` Joerg Roedel
2012-08-07 14:17 ` Bryan Schumaker
2012-08-07 14:27 ` Joerg Roedel
2012-08-07 14:36 ` Bryan Schumaker
2012-08-07 14:50 ` Joerg Roedel
2012-08-07 15:12 ` Bryan Schumaker
2012-08-07 15:19 ` Myklebust, Trond
2012-08-07 15:14 ` Myklebust, Trond
2012-08-07 15:18 ` Bryan Schumaker
2012-09-27 14:52 ` Joerg Roedel
2012-09-27 15:32 ` Myklebust, Trond
2012-09-27 15:39 ` Joerg Roedel
2012-09-27 16:16 ` Myklebust, Trond
2012-09-27 16:59 ` Linus Torvalds
2012-09-27 17:30 ` BUG_ON/panic proliferation Dave Jones
2012-09-28 0:52 ` Ryan Mallon
2012-09-28 10:08 ` Alan Cox [this message]
2012-09-27 21:21 ` kernel BUG at /data/lemmy/linux.trees.git/fs/nfs/idmap.c:681! Myklebust, Trond
2012-09-27 17:56 ` Joerg Roedel
2012-09-27 18:15 ` Bryan Schumaker
2012-09-28 12:17 ` Joerg Roedel
2012-09-28 13:21 ` Bryan Schumaker
2012-09-28 13:34 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928110829.5ab03cfe@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=davej@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®