From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: anisse@astier.eu, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, mmarek@suse.cz,
torvalds@linux-foundation.org, mchan@broadcom.com,
mcarlson@broadcom.com
Subject: Re: [PATCH 2/2] tg3: fix build-time dependency with IS_DEPENDENCY_SATISFIED()
Date: Mon, 01 Oct 2012 17:45:35 -0400 (EDT) [thread overview]
Message-ID: <20121001.174535.32880983714519058.davem@davemloft.net> (raw)
In-Reply-To: <20121001161059.GA27396@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Mon, 1 Oct 2012 12:10:59 -0400
> From e7c432cf5eb44b188c1aa2b188877c42300de8b9 Mon Sep 17 00:00:00 2001
> From: Paul Gortmaker <paul.gortmaker@windriver.com>
> Date: Mon, 1 Oct 2012 11:43:49 -0400
> Subject: [PATCH] tg3: unconditionally select HWMON support when tg3 is
> enabled.
>
> There is the seldom used corner case where HWMON=m at the same
> time as TIGON3=y (typically randconfigs) which will cause a link
> fail like:
>
> drivers/built-in.o: In function `tg3_close':
> tg3.c:(.text+0x16bd86): undefined reference to `hwmon_device_unregister'
> drivers/built-in.o: In function `tg3_hwmon_open':
> tg3.c:(.text+0x16fc4b): undefined reference to `hwmon_device_register'
> make[1]: *** [vmlinux] Error 1
>
> Fix it as suggested by DaveM[1] by having the Kconfig logic simply
> select HWMON when TIGON3 is selected. This gets rid of all the
> extra IS_ENABLED ifdeffery in tg3.c as a side benefit.
>
> [1] http://marc.info/?l=linux-netdev&m=134250573718151&w=2
>
> Cc: Michael Chan <mchan@broadcom.com>
> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Reported-by: Anisse Astier <anisse@astier.eu>
> Suggested-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied, thanks.
prev parent reply other threads:[~2012-10-01 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 12:21 [PATCH 1/2] kconfig: Introduce IS_DEPENDENCY_SATISFIED() Anisse Astier
2012-10-01 12:21 ` [PATCH 2/2] tg3: fix build-time dependency with IS_DEPENDENCY_SATISFIED() Anisse Astier
2012-10-01 16:10 ` Paul Gortmaker
2012-10-01 21:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001.174535.32880983714519058.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anisse@astier.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=mmarek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®