From: Arnd Bergmann <arnd@arndb.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: sameo@linux.intel.com, broonie@opensource.wolfsonmicro.com,
ashish.jangam@kpitcummins.com, dchen@diasemi.com,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 2/6] mfd: da9052: Introduce da9052-irq.c
Date: Thu, 4 Oct 2012 07:12:48 +0000 [thread overview]
Message-ID: <201210040712.48516.arnd@arndb.de> (raw)
In-Reply-To: <1349320509-26930-2-git-send-email-festevam@gmail.com>
On Thursday 04 October 2012, Fabio Estevam wrote:
> +static int da9052_map_irq(struct da9052 *da9052, int irq)
> +{
> + return regmap_irq_get_virq(da9052->irq_data, irq);
> +}
> +
> +int da9052_enable_irq(struct da9052 *da9052, int irq)
> +{
> + irq = da9052_map_irq(da9052, irq);
> + if (irq < 0)
> + return irq;
> +
> + enable_irq(irq);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(da9052_enable_irq);
This looks correct, but I'm not sure it's actually simpler
than letting the sub-drivers deal with calling regmap_irq_get_virq().
Can't each driver just call regmap_irq_get_virq once at init time and
then call the regular irq management functions?
Maybe I just don't see the real purpose of these functions. If I'm
contradicting what Mark said, listen to him instead.
Arnd
next prev parent reply other threads:[~2012-10-04 7:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 3:15 [PATCH 1/6] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe Fabio Estevam
2012-10-04 3:15 ` [PATCH 2/6] mfd: da9052: Introduce da9052-irq.c Fabio Estevam
2012-10-04 7:12 ` Arnd Bergmann [this message]
2012-10-04 11:14 ` Mark Brown
2012-10-04 12:17 ` Arnd Bergmann
2012-10-04 11:25 ` Mark Brown
2012-10-04 3:15 ` [PATCH 3/6] Input: da9052_tsi.c: Fix interrupt handling Fabio Estevam
2012-10-04 3:15 ` [PATCH 4/6] Input: da9052_onkey.c: Convert to the new da9052 interrupt functions Fabio Estevam
2012-10-05 18:57 ` Mark Brown
2012-10-04 3:15 ` [PATCH 5/6] power: da9052-battery: " Fabio Estevam
2012-10-05 18:58 ` Mark Brown
2012-11-18 4:20 ` Anton Vorontsov
2012-11-18 12:30 ` Fabio Estevam
2012-10-04 3:15 ` [PATCH 6/6] gpio: gpio-da9052: " Fabio Estevam
2012-10-04 11:26 ` Mark Brown
2012-10-08 6:20 ` Linus Walleij
2012-10-08 10:40 ` Fabio Estevam
2012-10-09 12:04 ` Linus Walleij
2012-10-09 12:19 ` Fabio Estevam
2012-10-04 11:26 ` [PATCH 1/6] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe Mark Brown
2012-11-12 16:22 ` Fabio Estevam
2012-11-18 23:44 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210040712.48516.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dchen@diasemi.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome