mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Huacai Chen <chenhc@lemote.com>,
	Charles Wang <muming.wq@taobao.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Seems like "sched: Add missing call to calc_load_exit_idle()" should be reverted in 3.5 branch
Date: Thu, 4 Oct 2012 10:46:26 -0700	[thread overview]
Message-ID: <20121004174626.GB14301@kroah.com> (raw)
In-Reply-To: <CAAhV-H54CJdg+UekpucZ=kOgCY5r5vvYQ+v4VwAMTCv+mCedXA@mail.gmail.com>

On Thu, Oct 04, 2012 at 12:11:01PM +0800, Huacai Chen wrote:
> Hi, Greg
> 
> I found that Linux-3.5.5 accept this commit "sched: Add missing call
> to calc_load_exit_idle()" but I think this isn't needed. Because
> "5167e8d5417b sched/nohz: Rewrite and fix load-avg computation --
> again not fully applied" is true for 3.6 branch, but not for 3.5
> branch.

But 5167e8d5417b is in 3.5, so shouldn't this commit still be necessary?

> In 3.5 branch, calc_load_exit_idle() is already called in
> tick_nohz_idle_exit(), it doesn't need to be called at
> tick_nohz_update_jiffies() again. In 3.6 branch, some code of
> tick_nohz_idle_exit() is splitted to tick_nohz_restart_sched_tick()
> and calc_load_exit_idle() is missing by accident, so commit "sched:
> Add missing call to calc_load_exit_idle()" is needed.

So this really should be dropped from 3.5?  Charles, Peter, Ingo, any
thoughts here?

thanks,

greg k-h

       reply	other threads:[~2012-10-04 17:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAhV-H54CJdg+UekpucZ=kOgCY5r5vvYQ+v4VwAMTCv+mCedXA@mail.gmail.com>
2012-10-04 17:46 ` Greg Kroah-Hartman [this message]
2012-10-04 18:31   ` Peter Zijlstra
2012-10-04 22:27     ` Greg Kroah-Hartman
2012-10-05 10:21       ` Peter Zijlstra
2012-10-05 16:17         ` Greg Kroah-Hartman
2012-10-05 17:10         ` Jonathan Nieder
2012-10-05 17:23           ` Peter Zijlstra
2012-10-08 11:33             ` Charles Wang
2012-10-05  1:39     ` Jonathan Nieder
2012-10-08 11:23       ` Charles Wang
2012-10-05  0:35 陈华才
2012-10-13  3:39 陈华才
2012-10-13  6:28 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121004174626.GB14301@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=chenhc@lemote.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=muming.wq@taobao.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®