From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755989Ab2JEAog (ORCPT ); Thu, 4 Oct 2012 20:44:36 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:41530 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024Ab2JEAoe (ORCPT ); Thu, 4 Oct 2012 20:44:34 -0400 Date: Fri, 5 Oct 2012 01:44:31 +0100 From: Al Viro To: Sasha Levin Cc: keescook@chromium.org, levinsasha928@gmail.com, davej@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs: handle failed audit_log_start properly Message-ID: <20121005004431.GN23473@ZenIV.linux.org.uk> References: <1349395051-12145-1-git-send-email-sasha.levin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349395051-12145-1-git-send-email-sasha.levin@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 04, 2012 at 07:57:31PM -0400, Sasha Levin wrote: > audit_log_start() may return NULL, this is unchecked by the caller in > audit_log_link_denied() and could cause a NULL ptr deref. > > Introduced by commit a51d9eaa ("fs: add link restriction audit reporting"). Again, -stable fodder. Applied.