mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Frediano Ziglio <frediano.ziglio@citrix.com>
Cc: "smfrench@gmail.com" <smfrench@gmail.com>,
	"sfrench@samba.org" <sfrench@samba.org>,
	"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
	"samba-technical@lists.samba.org"
	<samba-technical@lists.samba.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Convert properly UTF-8 to UTF-16
Date: Mon, 8 Oct 2012 07:26:58 -0400	[thread overview]
Message-ID: <20121008072658.0df25c55@tlielax.poochiereds.net> (raw)
In-Reply-To: <7CE799CC0E4DE04B88D5FDF226E18AC2E08D0408E8@LONPMAILBOX01.citrite.net>

On Mon, 8 Oct 2012 09:18:06 +0100
Frediano Ziglio <frediano.ziglio@citrix.com> wrote:

> On Wed, 2012-10-03 at 14:49 -0500, Steve French wrote:
> > Merged - but doesn't the reverse also have to be added in cifs_from_utf16?  ie
> > 
> >           utf16s_to_utf8s(uni, ... );
> > 
> 
> Not strictly necessary, at least to be able to mount shares.
> 

It probably is necessary if you want to be able to do anything
involving these filenames...

> > I am glad that someone added these multiword handling routines into
> > the kernel for FAT - this has been something we have wanted for a long
> > time in cifs (and smb2/smb3).  Note the comment in
> > fs/cifs/cifs_unicode.c
> > 
> > / * Note that some windows versions actually send multiword UTF-16 characters
> >  * instead of straight UTF16-2. The linux nls routines however aren't able to
> >  * deal with those characters properly. In the event that we get some of
> >  * those characters, they won't be translated properly.
> >  */
> > int
> > cifs_from_utf16(char *to, const __le16 *from, int tolen, int fromlen,
> >                  const struct nls_table *codepage, bool mapchar)
> > 
> 
> Should not be UCS-2 instead of UTF16-2 ??
> 
> > 
> > We could really use some nls test cases for cifs/smb2/smb3/nfs4 which
> > basically did various file, directory, symlink create/rename/delete
> > operations with various hard to map characters so we can test copying
> > to and from the server and ensure that we get the name mappings right
> > for these (and don't ever regress).   Fortunately smb2/smb3 is only
> > unicode so we don't have to deal with mappings to other codepages from
> > utf8
> > 
> 
> Do you have some framework/hook to put these tests ?
> 
> Where did you merge ? I cannot find nothing at
> http://gitweb.samba.org/?p=sfrench/cifs-2.6.git;a=summary
> 
> Regards
>   Frediano
> 

-- 
Jeff Layton <jlayton@redhat.com>

  reply	other threads:[~2012-10-08 11:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  9:33 Frediano Ziglio
2012-08-07 10:47 ` Jeff Layton
2012-08-28  7:28   ` Frediano Ziglio
2012-10-03 14:34     ` Frediano Ziglio
2012-10-03 19:49       ` Steve French
2012-10-08  8:18         ` Frediano Ziglio
2012-10-08 11:26           ` Jeff Layton [this message]
2012-10-08 14:04           ` Steve French
2012-10-09  4:43           ` Suresh Jayaraman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121008072658.0df25c55@tlielax.poochiereds.net \
    --to=jlayton@redhat.com \
    --cc=frediano.ziglio@citrix.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®