From: Greg KH <gregkh@linuxfoundation.org>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: "Wouter M. Koolen" <W.M.Koolen-Wijkstra@cwi.nl>,
lkml <linux-kernel@vger.kernel.org>,
jim.cromie@gmail.com, torvalds@linux-foundation.org,
akpm@linux-foundation.org, jbaron@redhat.com
Subject: Re: [bisected] stray angle bracket in dmesg
Date: Mon, 8 Oct 2012 08:35:36 -0700 [thread overview]
Message-ID: <20121008153536.GB17568@kroah.com> (raw)
In-Reply-To: <20121008141829.GA244@x4>
On Mon, Oct 08, 2012 at 04:18:29PM +0200, Markus Trippelsdorf wrote:
> On 2012.10.08 at 15:05 +0100, Wouter M. Koolen wrote:
> > Hi guys,
> >
> > After upgrading from 3.5.4 to 3.5.5 I started noticing log lines of the
> > form (just a random sample)
> >
> > pci_bus 0000:00: >resource 4 [io 0x0000-0x0cf7]
> > pnp 00:07: >Plug and Play ACPI device, IDs PNP0303 (active)
> > system 00:04: >[io 0x0680-0x069f] has been reserved
> > pci_root PNP0A08:00: >host bridge window [io 0x0000-0x0cf7]
> >
> > Note the right angle bracket between the device name and the message
> > string. These angle brackets were not there up till 3.5.4.
> >
> > This does not happen in all dmesg lines. Only the ones that start with a
> > device identifier.
> >
> > I assume this angle bracket was not intentional. Otherwise please excuse
> > the noise.
> >
> > I noticed this because all of these lines now suddenly slip through my
> > logcheck ignore rules.
> >
> > Bisection points to this commit:
> >
> > commit 3d822616ca81881d8c19d0b473e79ba241c700de
> > Author: Markus Trippelsdorf <markus@trippelsdorf.de>
> > Date: Sat Aug 18 18:35:51 2012 -0600
>
> This patch should be reverted for stable, since the move to ASCII SOH (
> commit 04d2c8c83d0) wasn't backported. So the fix just isn't necessary.
Ick, sorry about that, I'll go revert it for the next 3.5.y release,
thanks for letting me know.
greg k-h
prev parent reply other threads:[~2012-10-08 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 14:05 Wouter M. Koolen
2012-10-08 14:18 ` Markus Trippelsdorf
2012-10-08 15:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008153536.GB17568@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=W.M.Koolen-Wijkstra@cwi.nl \
--cc=akpm@linux-foundation.org \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®