From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()
Date: Tue, 9 Oct 2012 13:36:29 +0100 [thread overview]
Message-ID: <20121009123629.GB11061@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACVXFVONtkA5tUq3zcvrn6+RmC0_VLgeK5aR7g8yV2dJbgCysA@mail.gmail.com>
On Tue, Oct 09, 2012 at 08:02:18PM +0800, Ming Lei wrote:
> If loading via user space, timeout or not depends on userspace,
> at least udev won't timeout on non-existent firmware image.
This may be a mdev or old udev thing... it's definitely prevelant.
> Also looks request_firmware_nowait() is better for the case, _nowait()
> can avoid unnecessary delay and speedup firmware loading if there
> are more than one firmware to load.
It doesn't really help as the ABI is such that you can only have one
request_firmware() in play at once (unless this changed since I last
looked at it).
next prev parent reply other threads:[~2012-10-09 12:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 17:05 Mark Brown
2012-10-08 22:56 ` Ming Lei
2012-10-09 4:19 ` Mark Brown
2012-10-09 7:05 ` Ming Lei
2012-10-09 7:13 ` Mark Brown
2012-10-09 7:34 ` Ming Lei
2012-10-09 7:52 ` Mark Brown
2012-10-09 12:02 ` Ming Lei
2012-10-09 12:36 ` Mark Brown [this message]
2012-10-09 14:55 ` Ming Lei
2012-10-10 1:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009123629.GB11061@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome