From: Andrew Morton <akpm@linux-foundation.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Rusty Russell <rusty@rustcorp.com.au>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/3] lglock: make the per_cpu locks static
Date: Tue, 9 Oct 2012 14:46:17 -0700 [thread overview]
Message-ID: <20121009144617.7d7862b1.akpm@linux-foundation.org> (raw)
In-Reply-To: <1349754403-4798-2-git-send-email-laijs@cn.fujitsu.com>
On Tue, 9 Oct 2012 11:46:39 +0800
Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> The per_cpu locks are not used outside nor exported.
> Add a "static" linkage keyword to it.
I think a better description is:
: The per_cpu locks are not used outside the file which contains the
: DEFINE_LGLOCK(), so we can make these symbols static.
> --- a/include/linux/lglock.h
> +++ b/include/linux/lglock.h
> @@ -49,7 +49,7 @@ struct lglock {
> };
>
> #define DEFINE_LGLOCK(name) \
> - DEFINE_PER_CPU(arch_spinlock_t, name ## _lock) \
> + static DEFINE_PER_CPU(arch_spinlock_t, name ## _lock) \
> = __ARCH_SPIN_LOCK_UNLOCKED; \
> struct lglock name = { .lock = &name ## _lock }
>
> --
> 1.7.4.4
next prev parent reply other threads:[~2012-10-09 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 3:46 [PATCH 1/3] lglock: remove unused DEFINE_LGLOCK_LOCKDEP() Lai Jiangshan
2012-10-09 3:46 ` [PATCH 2/3] lglock: make the per_cpu locks static Lai Jiangshan
2012-10-09 21:46 ` Andrew Morton [this message]
2012-10-09 3:46 ` [PATCH 3/3] lglock: add DEFINE_STATIC_LGLOCK() Lai Jiangshan
2012-10-09 21:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009144617.7d7862b1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®