From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755917Ab2JJMpZ (ORCPT ); Wed, 10 Oct 2012 08:45:25 -0400 Received: from na3sys009aog119.obsmtp.com ([74.125.149.246]:40289 "EHLO na3sys009aog119.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562Ab2JJMpX (ORCPT ); Wed, 10 Oct 2012 08:45:23 -0400 Date: Wed, 10 Oct 2012 15:40:02 +0300 From: Felipe Balbi To: Andy Shevchenko Cc: viresh kumar , Andy Shevchenko , Vinod Koul , linux-kernel@vger.kernel.org, spear-devel , balbi@ti.com, Heikki Krogerus , Mika Westerberg Subject: Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver() Message-ID: <20121010124002.GF3197@arwen.pp.htv.fi> Reply-To: balbi@ti.com References: <1349178121-9105-1-git-send-email-andriy.shevchenko@linux.intel.com> <1349178121-9105-2-git-send-email-andriy.shevchenko@linux.intel.com> <1349859841.10584.122.camel@smile> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8TaQrIeukR7mmbKf" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8TaQrIeukR7mmbKf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar = wrote: > > On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko > > wrote: > >> On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote: > >>> From: Heikki Krogerus > >>> > >>> Since v3.2 we have nice macro to define the platform driver's init an= d exit > >>> calls. This patch simplifies the dw_dmac driver by using that macro. > >> > >> Actually we can't do this. It will break initialization of some other > >> drivers. > > > > why? >=20 > We have spi, i2c and hsuart devices connected to the DMA controller. > In case we would like to use DMA we have to have the dw_dmac loaded > before them. Currently we have spi driver on subsys_initcall level, > and Mika, who is developing it, will change to module_init_call level. > However, it will just hide the potential issue. He also tried to use > deferred module loading, but we don't know if it's good solution or > not, and that solution requires something to stop deferring at some > moment. >=20 > Might be we missed something and there is a better solution. if they can only work with DMA, they should return -EPROBE_DEFER so their probe() function can be called after DMA driver has finished probing. --=20 balbi --8TaQrIeukR7mmbKf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQdWyiAAoJEIaOsuA1yqREqi8P/2exBlkQnKZvOPe44e6hJQe7 G9Ln1IBDwTU7NY/zRVUmbRKL8Wtwfejbqq/V6z3c9yGsD0SmWK5IblUtqrZQw7Mp EEjs+Pg8VWSC4yHHqC+7ikATj48AyYE3VO21jeJXDtUhOv0Cay6gRa0yAsDrrrjh 2EUsC7QszB0av3cqRTxbGJOuQt4dVRfxcZOvXbzMcgzW6cfZOmFPUZHZEXqw1EpG lxI1egiydHDMbw5WK4dIcae7ylN7L6g2KnluSVIROKm6mBKukNuCYTINRh+P82q7 BnvgTCpB/qfT00lzAP1Y+BQ8J//TYkTz3J7HGZj7Tud524zQUU6LbTMzz9LfMhlX zHG8GPnJvLIk/WVyBr9uJ/mUVa6d+KbP0TCoaK+ITuV4dcq6nBZ5PGgWFEYMe5dJ YN6ahbMLg62oiWoFUfvrmgfCNFURM9uvTAAdHvpNKQyc7ni5MI0vLq1yM/yERbyX wbbg28uf8x4+VL44T/A4whxXPM3GT/Cwbzvdwk5ycRTDHkhyfT94D0Ga2UFuSLu/ KN/ZT7iDBhrOyCpCyB/nk4cUHBG4/kxFYNMcc+T7by+FUPRQerV4hr7sC1Hk/19O Cl5WgQTRlziDvIZmb4y+zOI+jpUy6FbI/KkKmLUw8xmqZHMCkR5ZqQTyz4BTmcs4 TmdwnwE/0LKrp6qWqzw1 =Wk4q -----END PGP SIGNATURE----- --8TaQrIeukR7mmbKf--