Re: [PATCH] driver/char/tpm: fix regression causesd by ppi

[Kent Yoder <key@linux.vnet.ibm.com>]

> >   Hmm, tpm_add_ppi is just sysfs_create_group, which only ever returns
> > 0. Looks like we can remove this error path, but PPI is unusable in the
> > failure case.
> 
> sysfs_create_group will return 0 on success or return error code. So I don't
> think we can remove this error path. The previous call to sysfs_create_group
> also have similar error path.

 Heh, seems "Returns 0 on success or error." doesn't mean what I
thought...

> >> +EXPORT_SYMBOL_GPL(tpm_add_ppi);
> >> ...
> >> +EXPORT_SYMBOL_GPL(tpm_remove_ppi);
> >> 
> >  Do we need to export these symbols?  These might have been left around
> > from when ppi was a standalone module.
> 
> We definitely need to export these symbols, since ppi was in tpm_bios.ko,
> and these symbols are called from tpm.ko.

  Yes, thanks.

Kent

> Jimmy