From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jarkko Huijts <jarkko.huijts@recoresystems.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3.6.1] usb: serial: ftdi_sio: Add missing chars_in_buffer function
Date: Wed, 10 Oct 2012 16:48:19 +0100 [thread overview]
Message-ID: <20121010164819.01c1a1c0@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20121010130506.GA5876@cora.recoresystems.com>
On Wed, 10 Oct 2012 15:05:06 +0200
Jarkko Huijts <jarkko.huijts@recoresystems.com> wrote:
> From: Jarkko Huijts <jarkko.huijts@gmail.com>
>
> The driver does not wait until the hardware buffer (for data from the PC to the
> UART line) is drained when tcdrain or close is called in an application.
> Solution: Implement a chars_in_buffer function that checks both the software
> and hardware buffer. If the TEMT (TX empty) bit of the line status register
> indicates the hw buffer is not empty, let the function return at least 1. This
> has been verified to work correctly with an FT232RL. The check on the hw buffer
> can not be done for the original SIO device.
>
> Signed-off-by: Jarkko Huijts <jarkko.huijts@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2012-10-10 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 13:05 Jarkko Huijts
2012-10-10 15:48 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010164819.01c1a1c0@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.huijts@recoresystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®