From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755206Ab2JKHCZ (ORCPT ); Thu, 11 Oct 2012 03:02:25 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:40645 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753793Ab2JKHCX (ORCPT ); Thu, 11 Oct 2012 03:02:23 -0400 Date: Thu, 11 Oct 2012 10:02:03 +0300 From: Dan Carpenter To: Krishna C Gudipati Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] [SCSI] bfa: cleanup a memcpy() Message-ID: <20121011070203.GG31607@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Smatch complains that we are writing more data than ->srlid_base member can hold. In fact, we are over writing the whole struct. I've re-written it to be a bit more clear and to silence the static checker warning. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 0116c10..a6dc18e 100644 --- a/drivers/scsi/bfa/bfa_ioc.c +++ b/drivers/scsi/bfa/bfa_ioc.c @@ -3624,11 +3624,9 @@ bfa_sfp_show_comp(struct bfa_sfp_s *sfp, struct bfi_mbmsg_s *msg) bfa_trc(sfp, sfp->memtype); if (sfp->memtype == BFI_SFP_MEM_DIAGEXT) { bfa_trc(sfp, sfp->data_valid); - if (sfp->data_valid) { - u32 size = sizeof(struct sfp_mem_s); - u8 *des = (u8 *) &(sfp->sfpmem->srlid_base); - memcpy(des, sfp->dbuf_kva, size); - } + if (sfp->data_valid) + memcpy(sfp->sfpmem, sfp->dbuf_kva, + sizeof(*sfp->sfpmem)); /* * Queue completion callback. */