From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH] perf ui/browser: Fix off-by-two bug on the first column
Date: Mon, 15 Oct 2012 11:57:50 +0200 [thread overview]
Message-ID: <20121015095749.GB1026@krava.brq.redhat.com> (raw)
In-Reply-To: <1350268438-5066-1-git-send-email-namhyung@kernel.org>
On Mon, Oct 15, 2012 at 11:33:58AM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> The commit 5395a04841fc ("perf hists: Separate overhead and baseline
> columns") makes the "Overhead" column no more the first one. So it
> resulted in the mis-aligned column in the normal (non-diff) output.
>
> Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
eek, missed that one ;) thanks!
Acked-by: Jiri Olsa <jolsa@redhat.com>
prev parent reply other threads:[~2012-10-15 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 19:50 perf hists indicator off by two spaces Markus Trippelsdorf
2012-10-15 2:33 ` [PATCH] perf ui/browser: Fix off-by-two bug on the first column Namhyung Kim
2012-10-15 9:57 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015095749.GB1026@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®