mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Qing Z <njumical@gmail.com>,
	mingo@kernel.org, ben@decadent.org.uk, markivx@codeaurora.org,
	linux-kernel@vger.kernel.org, cxie4@marvell.com,
	binw@marvell.com, wwang27@marvell.com, xjian@marvell.com,
	zhangwm@marvell.com, Qing Zhu <qzhu@marvell.com>
Subject: Re: [PATCH] panic: fix incomplete panic log in panic()
Date: Mon, 15 Oct 2012 15:06:39 -0700	[thread overview]
Message-ID: <20121015220639.GT2095@tassilo.jf.intel.com> (raw)
In-Reply-To: <20121015150204.6f837a39.akpm@linux-foundation.org>

> Also, we should be careful with things like up() on a semaphore which
> hasn't been down()ed.  Because under some Kconfig combinations, such an
> operation might trigger debugging traces and we could get into a big
> mess.  (An up() on non-down()ed semaphore is actually an OK operation,
> so this was a bad example.  But you see the problem).

iirc the debugging code normally checks oops_in_progress, so this shouldn't 
happen.

Agree on the rest of your email -- keep oops simple ... (KOSS)

-Andi

  reply	other threads:[~2012-10-15 22:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BD54883EA7DE8B41A61B7E723561C711139F75D348@sc-vexch3.marvell.com>
2012-10-15 11:38 ` Qing Z
2012-10-15 22:02   ` Andrew Morton
2012-10-15 22:06     ` Andi Kleen [this message]
2012-10-16 14:25     ` Qing Z
2012-10-17 10:44     ` Qing Z
2012-10-18  0:06       ` Andrew Morton
2012-10-22 14:54         ` Qing Z
2012-10-22 19:51           ` Andrew Morton
2012-10-11  8:03 Qing Zhu
2012-10-11 21:18 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121015220639.GT2095@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ben@decadent.org.uk \
    --cc=binw@marvell.com \
    --cc=cxie4@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markivx@codeaurora.org \
    --cc=mingo@kernel.org \
    --cc=njumical@gmail.com \
    --cc=qzhu@marvell.com \
    --cc=wwang27@marvell.com \
    --cc=xjian@marvell.com \
    --cc=zhangwm@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®