Re: [PATCHv2 4/4] dw_dmac: don't call platform_get_drvdata twice

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On Wed, Oct 17, 2012 at 01:31:18PM +0300, Andy Shevchenko wrote:

I would suggest adding a commit log, but if maintainer is fine without,
I'm fine too :-p

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

looks good:

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  drivers/dma/dw_dmac.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index 60b172a..7d2b438 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -1653,7 +1653,7 @@ static void dw_shutdown(struct platform_device *pdev)
>  {
>  	struct dw_dma	*dw = platform_get_drvdata(pdev);
>  
> -	dw_dma_off(platform_get_drvdata(pdev));
> +	dw_dma_off(dw);
>  	clk_disable_unprepare(dw->clk);
>  }
>  
> @@ -1662,7 +1662,7 @@ static int dw_suspend_noirq(struct device *dev)
>  	struct platform_device *pdev = to_platform_device(dev);
>  	struct dw_dma	*dw = platform_get_drvdata(pdev);
>  
> -	dw_dma_off(platform_get_drvdata(pdev));
> +	dw_dma_off(dw);
>  	clk_disable_unprepare(dw->clk);
>  
>  	return 0;
> -- 
> 1.7.10.4
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]