From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Alessandro Suardi <alessandro.suardi@gmail.com>
Subject: [PATCH 02/10] UAPI: Make uapi/linux/irqnr.h non-empty
Date: Wed, 17 Oct 2012 15:15:36 +0100 [thread overview]
Message-ID: <20121017141536.29084.8653.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20121017141521.29084.36722.stgit@warthog.procyon.org.uk>
uapi/linux/irqnr.h was emitted by the UAPI disintegration script as an empty
file because the parent linux/irqnr.h had no UAPI stuff in it, despite being
marked with "header-y".
Unfortunately, the patch program deletes the empty file when applying a kernel
patch.
It's not clear why this file is part of the UAPI at all. Looking in:
/usr/include/linux/irqnr.h
there's nothing there but a header reinclusion guard and a comment.
So just stick a comment in there as a placeholder.
Without this, if the kernel is fabricated from, say, a tarball and a patch, you
can get this error when building x86_64 or usermode Linux (and probably
others):
include/linux/irqnr.h:4:30: fatal error: uapi/linux/irqnr.h: No such file or directory
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Reported-by: Alessandro Suardi <alessandro.suardi@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Randy Dunlap <rdunlap@xenotime.net>
cc: Alessandro Suardi <alessandro.suardi@gmail.com>
---
include/uapi/linux/irqnr.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/irqnr.h b/include/uapi/linux/irqnr.h
index e69de29..ae5704f 100644
--- a/include/uapi/linux/irqnr.h
+++ b/include/uapi/linux/irqnr.h
@@ -0,0 +1,4 @@
+/*
+ * There isn't anything here anymore, but the file must not be empty or patch
+ * will delete it.
+ */
next prev parent reply other threads:[~2012-10-17 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 14:15 [PATCH 00/10] UAPI: Fixes David Howells
2012-10-17 14:15 ` [PATCH 01/10] uapi: Allow automatic generation of uapi/asm/ header files David Howells
2012-10-17 14:15 ` David Howells [this message]
2012-10-17 14:47 ` [PATCH 02/10] UAPI: Make uapi/linux/irqnr.h non-empty Geert Uytterhoeven
2012-10-17 14:15 ` [PATCH 03/10] UAPI: Remove empty conditionals from include/linux/Kbuild David Howells
2012-10-17 14:15 ` [PATCH 04/10] UAPI: Remove empty non-UAPI Kbuild files David Howells
2012-10-17 14:15 ` [PATCH 05/10] UAPI: Place comments in empty arch Kbuilds to make them non-empty David Howells
2012-10-17 15:42 ` Chris Metcalf
2012-10-17 14:16 ` [PATCH 06/10] UAPI: The tile arch uses the generic ucontext.h file David Howells
2012-10-17 15:43 ` Chris Metcalf
2012-10-17 14:16 ` [PATCH 07/10] UAPI: Put a comment into uapi/asm-generic/kvm_para.h and use it from arches David Howells
2012-10-17 14:16 ` [PATCH 08/10] UAPI: Make arch/mn10300/include/uapi/asm/setup.h non-empty David Howells
2012-10-17 14:16 ` [PATCH 09/10] UAPI: Make arch/sh/include/uapi/asm/hw_breakpoint.h non-empty David Howells
2012-10-17 14:16 ` [PATCH 10/10] UAPI: Make arch/sparc/include/uapi/asm/sigcontext.h non-empty David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017141536.29084.8653.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=alessandro.suardi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®