From: Ingo Molnar <mingo@kernel.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
eranian@gmail.com, "Meadows,
Lawrence F" <lawrence.f.meadows@intel.com>
Subject: Re: [PATCH 0/3] perf_event: enable overflow interrupts on KNC
Date: Wed, 17 Oct 2012 20:07:53 +0200 [thread overview]
Message-ID: <20121017180753.GA7291@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1210171256550.23243@vincent-weaver-1.um.maine.edu>
* Vince Weaver <vincent.weaver@maine.edu> wrote:
> Hello
>
> the following patchset enables overflow interrupts on Knights Corner,
> the initial KNC PMU driver that was included in 3.7-rc1 did not
> support this.
Nice!
> The first patch should be straightforward.
> The second should be too, but it relates to a problem with the p6 PMU
> that I brought up in a separate thread.
> The third patch copies code over from the perf_event_intel.c interrupt
> handler. Unfortunately KNC and x86 architectural perfmon use
> different MSR numbers. The proper fix might be to make this
> generic and have function vectors for the status/ack functions,
> but since they are inline and probably performance critical
> I took the easy way out and just duplicated the code.
The duplication looks pretty limited to me, so I don't think
it's a problem.
How well tested is this on real hardware and how robust is the
hardware with this? Since it's a new PMU driver for v3.7, and if
these are reasonably well tested, then we could send these to
Linus via perf/urgent, so that they don't miss and have to wait
all the way to v3.8.
Thanks,
Ingo
next prev parent reply other threads:[~2012-10-17 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 17:02 Vince Weaver
2012-10-17 17:03 ` [PATCH 1/3] Make KNC use full 40-bit width of counters Vince Weaver
2012-10-24 10:34 ` [tip:perf/urgent] perf/x86: Make Intel " tip-bot for Vince Weaver
2012-10-17 17:04 ` [PATCH 2/3] perf_event: Remove cpuc->enable check on KNC event enable/disable Vince Weaver
2012-10-24 10:35 ` [tip:perf/urgent] perf/x86: Remove cpuc-> enable check on Intl " tip-bot for Vince Weaver
2012-10-17 17:05 ` [PATCH 3/3] perf_event: Enable overflow on KNC with a custom knc_pmu_handle_irq() Vince Weaver
2012-10-24 10:36 ` [tip:perf/urgent] perf/x86: Enable overflow on Intel " tip-bot for Vince Weaver
2012-10-17 18:07 ` Ingo Molnar [this message]
2012-10-17 20:24 ` [PATCH 0/3] perf_event: enable overflow interrupts on KNC Vince Weaver
2012-10-17 21:47 ` Ingo Molnar
2012-10-18 17:54 ` Vince Weaver
2012-10-18 18:54 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017180753.GA7291@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=eranian@gmail.com \
--cc=lawrence.f.meadows@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome