From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sangho Yi <antiroot@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Drivers: Staging: CSR: Fixed indentation problems on data_tx.c
Date: Thu, 18 Oct 2012 16:31:06 +0300 [thread overview]
Message-ID: <20121018133106.GN5685@mwanda> (raw)
In-Reply-To: <1350227813-30880-1-git-send-email-antiroot@gmail.com>
On Mon, Oct 15, 2012 at 12:16:50AM +0900, Sangho Yi wrote:
> @@ -15,36 +15,37 @@
> #include "csr_wifi_hip_unifi.h"
> #include "unifi_priv.h"
>
> -int
> -uf_verify_m4(unifi_priv_t *priv, const unsigned char *packet, unsigned int length)
> -{
> - const unsigned char *p = packet;
> - u16 keyinfo;
> +int uf_verify_m4 (unifi_priv_t *priv, const unsigned char *packet,
> + unsigned int length) {
The original was correct. The new code is wrong.
regards,
dan carpenter
next prev parent reply other threads:[~2012-10-18 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 15:16 Sangho Yi
2012-10-14 15:16 ` [PATCH 2/4] Drivers: Staging: CSR: Removed braces for single line if statement Sangho Yi
2012-10-22 21:02 ` Greg KH
2012-10-14 15:16 ` [PATCH 3/4] Drivers: Staging: CSR: Removed whitespace between function name and ( Sangho Yi
2012-10-22 21:02 ` Greg KH
2012-10-14 15:16 ` [PATCH 4/4] Drivers: Staging: CSR: Removed whitespace before quoting newline Sangho Yi
2012-10-22 21:03 ` Greg KH
2012-10-18 13:31 ` Dan Carpenter [this message]
2012-10-22 21:00 ` [PATCH 1/4] Drivers: Staging: CSR: Fixed indentation problems on data_tx.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018133106.GN5685@mwanda \
--to=dan.carpenter@oracle.com \
--cc=antiroot@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome