From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Bob Liu <lliubbo@gmail.com>,
aarcange@redhat.com, xiaoguangrong@linux.vnet.ibm.com,
hughd@google.com, linux-kernel@vger.kernel.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH 3/4] thp: introduce hugepage_vma_check()
Date: Thu, 18 Oct 2012 13:32:25 -0700 [thread overview]
Message-ID: <20121018133225.53f0e247.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1210181315480.26994@chino.kir.corp.google.com>
On Thu, 18 Oct 2012 13:16:04 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:
> On Thu, 18 Oct 2012, Bob Liu wrote:
>
> > Multi place do the same check.
> >
>
> This only succeeds in removing four lines and makes the code more
> difficult to follow
I like it. It takes a bunch of code sequences which may or may not be the
same and removes all doubt, while making the call sites clearer.
next prev parent reply other threads:[~2012-10-18 20:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 10:12 [PATCH 1/4] thp: clean up __collapse_huge_page_isolate Bob Liu
2012-10-18 10:12 ` [PATCH 2/4] thp: introduce hugepage_get_pmd() Bob Liu
2012-10-18 20:15 ` David Rientjes
2012-10-18 10:12 ` [PATCH 3/4] thp: introduce hugepage_vma_check() Bob Liu
2012-10-18 20:16 ` David Rientjes
2012-10-18 20:32 ` Andrew Morton [this message]
2012-10-18 10:12 ` [PATCH 4/4] thp: cleanup: introduce mk_huge_pmd() Bob Liu
2012-10-18 20:13 ` [PATCH 1/4] thp: clean up __collapse_huge_page_isolate David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018133225.53f0e247.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lliubbo@gmail.com \
--cc=rientjes@google.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®