From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: YAMANE Toshiaki <yamanetoshi@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging/sbe-2t3e3: Use netdev_ printks in main.c
Date: Fri, 19 Oct 2012 12:10:38 -0700 [thread overview]
Message-ID: <20121019191038.GA18369@kroah.com> (raw)
In-Reply-To: <1348754271-4987-1-git-send-email-yamanetoshi@gmail.com>
On Thu, Sep 27, 2012 at 10:57:51PM +0900, YAMANE Toshiaki wrote:
> fixed below checkpatch warning.
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Your coding style cleanup patch introduced more coding style errors, not
good. Please always remember to use checkpatch.pl on your patches you
create.
please fix up.
greg k-h
next prev parent reply other threads:[~2012-10-19 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 13:57 YAMANE Toshiaki
2012-09-27 13:59 ` [PATCH 2/3] staging/sbe-2t3e3: Use netdev_ or dev_ or pr_ printks in module.c YAMANE Toshiaki
2012-10-19 19:09 ` Greg Kroah-Hartman
2012-10-24 2:52 ` YAMANE Toshiaki
2012-09-27 13:59 ` [PATCH 3/3] staging/sbe-2t3e3: Use netdev_ printks in cpld.c YAMANE Toshiaki
2012-10-19 19:10 ` Greg Kroah-Hartman [this message]
2012-10-24 3:05 ` [PATCH 1/3] staging/sbe-2t3e3: Use netdev_ printks in main.c YAMANE Toshiaki
2012-10-24 4:15 ` Greg Kroah-Hartman
2012-10-24 5:38 ` Toshiaki Yamane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019191038.GA18369@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome