mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	mingo@redhat.com, linux-kernel@vger.kernel.org,
	aarcange@redhat.com, Michel Lespinasse <walken@google.com>
Subject: Re: [PATCH 2/2] rename NUMA fault handling functions
Date: Fri, 19 Oct 2012 22:54:07 +0200	[thread overview]
Message-ID: <20121019205407.GA9132@gmail.com> (raw)
In-Reply-To: <50815EA5.5080502@redhat.com>


* Rik van Riel <riel@redhat.com> wrote:

> On 10/19/2012 07:41 AM, Peter Zijlstra wrote:
> >On Thu, 2012-10-18 at 17:20 -0400, Rik van Riel wrote:
> >>Having the function name indicate what the function is used
> >>for makes the code a little easier to read.  Furthermore,
> >>the fault handling code largely consists of do_...._page
> >>functions.
> >
> > I don't much care either way, but I was thinking walken 
> > might want to use something similar to do WSS estimation, in 
> > which case the NUMA name is just as wrong.
> 
> That's a good point. I had not considered other uses of the 
> same code.

Renaming the functions for more clarity still makes sense IMO: 
we could give it a _wss or _working_set prefix/postfix?

Thanks,

	Ingo

  reply	other threads:[~2012-10-19 20:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 21:18 [PATCH 0/2] minor NUMA cleanups & documentation Rik van Riel
2012-10-18 21:19 ` [PATCH 1/2] add credits for NUMA placement Rik van Riel
2012-10-19 11:41   ` Peter Zijlstra
2012-10-19 12:02   ` [tip:numa/core] numa: Add " tip-bot for Rik van Riel
2012-10-28 17:11   ` [tip:numa/core] sched, numa, mm: " tip-bot for Rik van Riel
2012-11-13 15:31   ` tip-bot for Rik van Riel
2012-11-13 17:23   ` tip-bot for Rik van Riel
2012-11-19 19:46   ` tip-bot for Rik van Riel
2012-10-18 21:20 ` [PATCH 2/2] rename NUMA fault handling functions Rik van Riel
2012-10-19 11:41   ` Peter Zijlstra
2012-10-19 14:07     ` Rik van Riel
2012-10-19 20:54       ` Ingo Molnar [this message]
2012-10-21 12:50         ` [PATCH 4/2] numa, mm: Rename the PROT_NONE " Ingo Molnar
2012-10-21 13:22           ` Rik van Riel
2012-10-21 13:29             ` Ingo Molnar
2012-10-21 13:43               ` Ingo Molnar
2012-10-20 10:15     ` [PATCH 2/2] rename NUMA " Michel Lespinasse
2012-10-21 15:20   ` [tip:numa/core] numa, mm: Rename the PROT_NONE fault handling functions to *_numa() tip-bot for Rik van Riel
2012-10-23 11:00   ` tip-bot for Rik van Riel
2012-10-21 12:43 ` [PATCH 3/2] sched, numa, mm: Implement constant rate working set sampling Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121019205407.GA9132@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=riel@redhat.com \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome