From: Greg KH <gregkh@linuxfoundation.org>
To: Adil Mujeeb <mujeeb.adil@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, pavel@ucw.cz
Subject: Re: [PATCH 0/9] Staging: winbond: Fixed coding style issues
Date: Tue, 23 Oct 2012 11:45:55 -0700 [thread overview]
Message-ID: <20121023184555.GA3597@kroah.com> (raw)
In-Reply-To: <CANBXnMkt-yFe6TRmbrMKdzxi0oUGB8233nF-5-376Ld+P+3CGA@mail.gmail.com>
On Tue, Oct 23, 2012 at 03:41:08PM +0530, Adil Mujeeb wrote:
> On Tue, Oct 23, 2012 at 2:04 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Oct 12, 2012 at 10:07:06PM +0530, Adil Mujeeb wrote:
> >>
> >> winbond directory files have lots of coding style issues. The patch set tries to remove *most* (if not all) of the coding style issues. checkpatch.pl script is still complaining (like 80 characters limit) but major part of the serious coding style issues have been rectified.
> >
> > None of your patches can be applied due to the wrong patch level they
> > were generated at. Please redo them, drop the two offending patches,
> > and resend the whole series.
> >
> > thanks,
> >
> > greg k-h
>
> Thanks Greg. I will recreate the patches and shall drop the mentioned
> ones. But I am still not able find where I am doing wrong in
> generating the patches. I am following your tutorial :) but may be
> missing something. Please help. I am doing in the following ways:
>
> 1. I am downloading the latest rc source archive from ftp.kernel.org
> under directory /pub/linux/kernel/v3.x/testing
> 2. Then creating my own git repository treating the base source as master.
Why not just use the kernel git tree? You will have to work off of
linux-next if you want to send staging patches, you can not keep up with
development otherwise.
> 3. Creating a branch from it and tries to fix some sources.
> 4. Create the patch through git format-patch
> 5. Submit the patch through git send-email command.
>
> Dry run works fine with my repository. Could you please help?
Your patches could not be applied with "patch -p1" from the root of the
kernel source tree, I think you created your git repo one directory too
deep.
greg k-h
next prev parent reply other threads:[~2012-10-23 18:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 16:37 Adil Mujeeb
2012-10-12 16:37 ` [PATCH 1/9] Staging: winbond: wbusb: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 2/9] Staging: winbond: phy_calibration: " Adil Mujeeb
2012-10-12 16:53 ` Joe Perches
2012-10-21 10:38 ` Pavel Machek
2012-10-12 16:37 ` [PATCH 3/9] Staging: winbond: mds: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 4/9] Staging: winbond: sem_api: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 5/9] Staging: winbond: wb35reg: Fixed coding style issues Adil Mujeeb
2012-10-21 10:39 ` Pavel Machek
2012-10-12 16:37 ` [PATCH 6/9] Staging: winbond: wb35rx_f: " Adil Mujeeb
2012-10-12 16:37 ` [PATCH 7/9] Staging: winbond: wb35rx_s: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 8/9] taging: winbond: wb35tx: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 9/9] Staging: winbond: wb35tx_s: " Adil Mujeeb
2012-10-21 10:42 ` [PATCH 0/9] Staging: winbond: " Pavel Machek
2012-10-21 11:22 ` Adil Mujeeb
2012-10-22 20:34 ` Greg KH
2012-10-23 10:11 ` Adil Mujeeb
2012-10-23 18:45 ` Greg KH [this message]
2012-11-07 18:52 ` Adil Mujeeb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023184555.GA3597@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome