From: MITSUNARI Shigeo <herumi@nifty.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: fs: page cache wrongly left invalidated after revalidate_disk
Date: Thu, 25 Oct 2012 06:11:17 +0900 [thread overview]
Message-ID: <201210242111.q9OLBL28027212@msag502.nifty.com> (raw)
In-Reply-To: (Your message of "Wed, 24 Oct 2012 09:44:23 -0400") <x491ugo6l3c.fsf@segfault.boston.devel.redhat.com>
Jeff Moyer <jmoyer@redhat.com> writes:
> rescan_partitions (called in the bdev open path) should reset
> bd_invalidated. I think you need to dig into why that isn't happening.
rescan_partitions() and invalidate_partitions() reset bd_invalidated
after calling check_disk_size_change(). But revalidate_disk() does not it.
So, I think bdev->bd_invalidated = 0 is necessary for revalidate_disk(),
or check_disk_size_change() should be it more simply.
Yours,
Shigeo
next prev parent reply other threads:[~2012-10-24 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 22:29 MITSUNARI Shigeo
2012-10-24 13:44 ` Jeff Moyer
2012-10-24 21:11 ` MITSUNARI Shigeo [this message]
2012-10-24 23:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210242111.q9OLBL28027212@msag502.nifty.com \
--to=herumi@nifty.com \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®