From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161247Ab2JXVl0 (ORCPT ); Wed, 24 Oct 2012 17:41:26 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:53356 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161210Ab2JXVlY (ORCPT ); Wed, 24 Oct 2012 17:41:24 -0400 Date: Wed, 24 Oct 2012 23:20:03 +0200 From: Francois Romieu To: Hayes Wang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jean@google.com Subject: Re: [PATCH v3 net-next] r8169: enable ALDPS for power saving Message-ID: <20121024212003.GA11152@electric-eye.fr.zoreil.com> References: <1350893153-18320-1-git-send-email-hayeswang@realtek.com> <1351059843-1464-1-git-send-email-hayeswang@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1351059843-1464-1-git-send-email-hayeswang@realtek.com> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hayes Wang : > Enable ALDPS function to save power when link down. Note that the > feature should be set after the other PHY settings. And the firmware > is necessary. Don't enable it without loading the firmware. > > None of the firmware-free chipsets support ALDPS. Neither do the > RTL8168d/8111d. > > For 8136 series, make sure the ALDPS is disabled before loading the > firmware. For 8168 series, the ALDPS would be disabled automatically > when loading firmware. You must not disable it directly. > > Signed-off-by: Hayes Wang Acked-by: Francois Romieu