From: Olaf Hering <olaf@aepfle.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen PVonHVM: move shared_info to reserved memory area
Date: Thu, 25 Oct 2012 11:31:10 +0200 [thread overview]
Message-ID: <20121025093110.GA29278@aepfle.de> (raw)
In-Reply-To: <5089202E02000078000A45E7@nat28.tlf.novell.com>
On Thu, Oct 25, Jan Beulich wrote:
> >>> On 25.10.12 at 11:04, Olaf Hering <olaf@aepfle.de> wrote:
> > @@ -1495,38 +1494,53 @@ asmlinkage void __init xen_start_kernel(void)
> > #endif
> > }
> >
> > -void __ref xen_hvm_init_shared_info(void)
>
> Was the __ref here in fact unnecessary (i.e. did you check that
> its removal doesn't cause any section mismatch warnings)?
It does not cause any warnings for me.
> > +static void xen_hvm_set_shared_info(struct shared_info *sip)
>
> With its sole caller being __init, this should also be __init.
Thanks, I will respin the patch with this change.
Olaf
prev parent reply other threads:[~2012-10-25 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 9:04 Olaf Hering
2012-10-25 9:19 ` [Xen-devel] " Jan Beulich
2012-10-25 9:31 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025093110.GA29278@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome