From: Davide Ciminaghi <ciminaghi@gnudd.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, rubini@gnudd.com,
giancarlo.asnaghi@st.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support
Date: Thu, 25 Oct 2012 14:22:43 +0200 [thread overview]
Message-ID: <20121025122243.GD29674@mail.gnudd.com> (raw)
In-Reply-To: <20121024124955.GF18814@opensource.wolfsonmicro.com>
On Wed, Oct 24, 2012 at 01:49:55PM +0100, Mark Brown wrote:
> On Wed, Oct 24, 2012 at 02:31:18PM +0200, Davide Ciminaghi wrote:
> > On Tue, Oct 23, 2012 at 06:18:38PM +0100, Mark Brown wrote:
>
...
>
> > My opinion is that passing function pointers for
> > readable/writeable/precious/volatile methods could still be useful when
> > registers' features or access properties can change at runtime (for instance a
>
> This is essential for sparse register maps, really.
yes, I realized that when updating sta2x11-mfd to the new table driven approach
yesterday. One more thing I found is that you can have the case in which, for
instance, almost all readable registers are also writeable. To address such a
case, I added the possibility for a user to specify ranges for which a given
property is false, so that, in the above example, you first check whether a
given register belongs to the non-writeable region and then maybe skip the
other checks.
I'm sending a regmap patch in few minutes.
Thanks and regards
Davide
next prev parent reply other threads:[~2012-10-25 12:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 14:50 [PATCH v2 00/10] sta2x11-mfd patches ciminaghi
2012-10-22 14:50 ` [PATCH 01/10] drivers/mfd/sta2x11-mfd: add apb-soc regs driver and factor out common code ciminaghi
2012-10-22 14:50 ` [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support ciminaghi
2012-10-23 17:18 ` Mark Brown
2012-10-24 12:31 ` Davide Ciminaghi
2012-10-24 12:49 ` Mark Brown
2012-10-25 12:22 ` Davide Ciminaghi [this message]
2012-10-22 14:50 ` [PATCH 03/10] drivers/mfd/sta2x11-mfd: add sta2x11_mfd_get_regs_data() function ciminaghi
2012-10-22 14:50 ` [PATCH 04/10] drivers/mfd/sta2x11-mfd: use defines for platform devices' names ciminaghi
2012-10-22 14:50 ` [PATCH 05/10] drivers/mfd/sta2x11-mfd: only add sta2x11_mfd if it hasn't already been added ciminaghi
2012-10-22 14:50 ` [PATCH 06/10] drivers/mfd/sta2x11-mfd: platform probe: don't mind about gpio platform data ciminaghi
2012-10-22 14:50 ` [PATCH 07/10] drivers/mfd/sta2x11-mfd: use one lock per device instead of one lock per mfd ciminaghi
2012-10-22 14:50 ` [PATCH 08/10] drivers/mfd/sta2x11-mfd: add scr (otp registers) platform driver ciminaghi
2012-10-22 14:50 ` [PATCH 09/10] drivers/mfd/sta2x11-mfd: add defines for some sta2x11 sctl registers ciminaghi
2012-10-22 14:50 ` [PATCH 10/10] drivers/mfd/sta2x11-mfd: add myself to copyright ciminaghi
2012-10-25 5:35 ` [PATCH v2 00/10] sta2x11-mfd patches Alessandro Rubini
2012-11-09 14:19 [PATCH v3 " ciminaghi
2012-11-09 14:19 ` [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support ciminaghi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025122243.GD29674@mail.gnudd.com \
--to=ciminaghi@gnudd.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=giancarlo.asnaghi@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome