From: Bin Gao <bin.gao@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Len Brown <len.brown@intel.com>
Subject: Re: arch/x86/Kconfig: not select X86_MPPARSE when SFI is present
Date: Thu, 25 Oct 2012 09:29:38 -0700 [thread overview]
Message-ID: <20121025162937.GA38477@bingao-desk1.fm.intel.com> (raw)
In-Reply-To: <20121025075752.GE3712@gmail.com>
Yes, your suggested descriptions more match the change.
I'm sending a new patch for your review. Thanks.
-Bin
On Thu, Oct 25, 2012 at 09:57:52AM +0200, Ingo Molnar wrote:
>
> * Bin Gao <bin.gao@linux.intel.com> wrote:
>
> > MPS tables are not needed for systems that have proper ACPI support.
> > This is also true for systems that have SFI in place.
> >
> > So this patch is to exclude X86_MPPARSE when either ACPI or SFI is present.
> >
> > Signed-off-by: Bin Gao <bin.gao@intel.com>
> > ---
> > arch/x86/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 46c3bff..b1494bd 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -310,7 +310,7 @@ config X86_X2APIC
> > If you don't know what to do here, say N.
> >
> > config X86_MPPARSE
> > - bool "Enable MPS table" if ACPI
> > + bool "Enable MPS table" if ACPI || SFI
> > default y
> > depends on X86_LOCAL_APIC
> > ---help---
>
> The changelog does not seem to match the patch. Did you want to
> say:
>
> " So this patch allows the configuration (turning off) of
> CONFIG_X86_MPPARSE when either ACPI or SFI is present. "
>
> ?
>
> Ingo
prev parent reply other threads:[~2012-10-26 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 6:04 Bin Gao
2012-10-25 7:57 ` Ingo Molnar
2012-10-25 16:29 ` Bin Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025162937.GA38477@bingao-desk1.fm.intel.com \
--to=bin.gao@linux.intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®