From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936040Ab2JYRm1 (ORCPT ); Thu, 25 Oct 2012 13:42:27 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:48734 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757050Ab2JYRmZ (ORCPT ); Thu, 25 Oct 2012 13:42:25 -0400 Date: Thu, 25 Oct 2012 10:42:20 -0700 From: Tejun Heo To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh Subject: Re: [PATCH 4/6] cgroups: forbid pre_destroy callback to fail Message-ID: <20121025174220.GJ11442@htj.dyndns.org> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-5-git-send-email-mhocko@suse.cz> <20121018224148.GR13370@google.com> <20121019133244.GE799@dhcp22.suse.cz> <20121019202405.GR13370@google.com> <20121022103021.GA6367@dhcp22.suse.cz> <20121024192535.GG12182@atj.dyndns.org> <20121025143756.GI11105@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121025143756.GI11105@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, Michal. On Thu, Oct 25, 2012 at 04:37:56PM +0200, Michal Hocko wrote: > I am not sure I understand you here. So are you suggesting > s/BUG_ON/WARN_ON_ONCE/ in this patch? Oh, no, I meant that we can do upto patch 3 of this series and then follow up with proper cgroup core update and then stack further memcg cleanups on top. > > Let's create a cgroup branch and build things there. I don't think > > cgroup changes are gonna be a single patch and expect to see at least > > some bug fixes afterwards and don't wanna keep them floating separate > > from other cgroup changes. > > > mm being based on top of -next, that should work, right? > > Well, a tree based on -next is, ehm, impractical. I can create a bug on > top of my -mm git branch (where I merge your cgroup common changes) for > development and then when we are ready we can send it as a series and > push it via Andrew. Would that work for you? > Or we can push the core part via Andrew, wait for the merge and work on > the follow up cleanups later? > It is not like the follow up part is really urgent, isn't it? I would > just like the memcg part settled first because this can potentially > conflict with other memcg work. Argh... can we pretty *please* just do a plain git branch? I don't care where it is but I want to be able to pull it into cgroup core and yes I do wanna make this happen in this devel cycle. We've been sitting on it far too long waiting for memcg. Thanks. -- tejun