mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxim Patlasov <mpatlasov@parallels.com>
To: miklos@szeredi.hu
Cc: fuse-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	devel@openvz.org
Subject: [PATCH 05/12] fuse: rework fuse_perform_write()
Date: Fri, 26 Oct 2012 19:49:00 +0400	[thread overview]
Message-ID: <20121026154857.18931.40556.stgit@maximpc.sw.ru> (raw)
In-Reply-To: <20121026152957.18931.46330.stgit@maximpc.sw.ru>

The patch allocates as many page pointers in fuse_req as needed to cover
interval [pos .. pos+len-1]. Inline helper fuse_wr_pages() is introduced
to hide this cumbersome arithmetic.

Signed-off-by: Maxim Patlasov <mpatlasov@parallels.com>
---
 fs/fuse/file.c |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 9872acc..ba505bc 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -881,11 +881,19 @@ static ssize_t fuse_fill_write_pages(struct fuse_req *req,
 		if (!fc->big_writes)
 			break;
 	} while (iov_iter_count(ii) && count < fc->max_write &&
-		 req->num_pages < FUSE_MAX_PAGES_PER_REQ && offset == 0);
+		 req->num_pages < req->max_pages && offset == 0);
 
 	return count > 0 ? count : err;
 }
 
+static inline unsigned fuse_wr_pages(loff_t pos, size_t len)
+{
+	return min_t(unsigned,
+		     ((pos + len - 1) >> PAGE_CACHE_SHIFT) -
+		     (pos >> PAGE_CACHE_SHIFT) + 1,
+		     FUSE_MAX_PAGES_PER_REQ);
+}
+
 static ssize_t fuse_perform_write(struct file *file,
 				  struct address_space *mapping,
 				  struct iov_iter *ii, loff_t pos)
@@ -901,8 +909,9 @@ static ssize_t fuse_perform_write(struct file *file,
 	do {
 		struct fuse_req *req;
 		ssize_t count;
+		unsigned nr_pages = fuse_wr_pages(pos, iov_iter_count(ii));
 
-		req = fuse_get_req(fc, FUSE_MAX_PAGES_PER_REQ);
+		req = fuse_get_req(fc, nr_pages);
 		if (IS_ERR(req)) {
 			err = PTR_ERR(req);
 			break;


  parent reply	other threads:[~2012-10-26 15:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 15:47 [PATCH v3 00/12] fuse: optimize scatter-gather direct IO Maxim Patlasov
2012-10-26 15:48 ` [PATCH 01/12] fuse: general infrastructure for pages[] of variable size Maxim Patlasov
2012-10-26 15:48 ` [PATCH 02/12] fuse: categorize fuse_get_req() Maxim Patlasov
2012-10-26 15:48 ` [PATCH 03/12] fuse: rework fuse_retrieve() Maxim Patlasov
2012-10-26 15:48 ` [PATCH 04/12] fuse: rework fuse_readpages() Maxim Patlasov
2012-10-26 15:49 ` Maxim Patlasov [this message]
2012-10-26 15:49 ` [PATCH 06/12] fuse: rework fuse_do_ioctl() Maxim Patlasov
2012-10-26 15:49 ` [PATCH 07/12] fuse: add per-page descriptor <offset, length> to fuse_req Maxim Patlasov
2012-10-26 15:49 ` [PATCH 08/12] fuse: use req->page_descs[] for argpages cases Maxim Patlasov
2012-10-26 15:50 ` [PATCH 09/12] mm: minor cleanup of iov_iter_single_seg_count() Maxim Patlasov
2012-10-26 15:50 ` [PATCH 10/12] fuse: pass iov[] to fuse_get_user_pages() Maxim Patlasov
2012-10-26 15:50 ` [PATCH 11/12] fuse: optimize fuse_get_user_pages() Maxim Patlasov
2012-10-26 15:50 ` [PATCH 12/12] fuse: optimize __fuse_direct_io() Maxim Patlasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026154857.18931.40556.stgit@maximpc.sw.ru \
    --to=mpatlasov@parallels.com \
    --cc=devel@openvz.org \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome