From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"mingo@elte.hu" <mingo@elte.hu>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [BUG] perf parser: does not support arbitrary new sysfs events
Date: Sat, 27 Oct 2012 22:34:27 +0200 [thread overview]
Message-ID: <20121027203427.GB9099@krava.redhat.com> (raw)
In-Reply-To: <CABPqkBRBcYqBqhitAF0u6o1+TZqaRREMvb+ie_bbTaK3JdAB3Q@mail.gmail.com>
On Fri, Oct 26, 2012 at 10:23:09PM +0200, Stephane Eranian wrote:
> Hi,
>
> The latest round of perf parser changes broke my PEBS-LL patch series
> (at the last minute). For PEBS-LL, I need to add to generic events but I want
> to keep them PMU specific. As such, they need to live in the sysfs events
> subdir: /sys/devices/cpu/events/mem-loads, sys/devices/cpu/events/mem-stores.
>
> Given your latest rounds of sysfs event changes, I had to modify my kernel
> patches to fit those two new events within your perf_pmu_events_attr tables.
>
> But now, when I try to do:
>
> $ perf record -e cpu/mem-loads/ ....
I can try this only on on uncore events and hw events aliases and that seems to work
>
> I get unsupported event. Looks at the syscall trace, it seems perf does not even
> look into the sysfs subdir to find a possible match. I don't
> understand that. What's
> the point of sysfs event list if it is not used or cannot be extended?
>
> Note that when I explicitly pass the content of the sysfs file to perf
> record, it
> works:
>
> $ perf record -e cpu/event=0xcd,umask=0x1,ldlat=3/ ......
>
> So this is clearly a problem with the lookup in sysfs.
>
> Also if you have the mappings exposed now in sysfs, why keep the hardcoded
> generic events as well? Or why have those events hardcoded in the parser as
> well.
having perf work on old kernels
>
> I don't understand all this parser code. I get the feeling it is
> getting a bit out of
> hands already. But now, I am stuck. So could you fix my parser problem ASAP?
yep, but need more details.. related patches would help
jirka
next prev parent reply other threads:[~2012-10-27 20:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 20:23 Stephane Eranian
2012-10-27 20:34 ` Jiri Olsa [this message]
2012-10-27 23:13 ` Stephane Eranian
2012-10-27 23:47 ` Jiri Olsa
2012-10-29 1:50 ` Andi Kleen
2012-10-29 9:43 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121027203427.GB9099@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome