From: Greg KH <gregkh@linuxfoundation.org>
To: George Zhang <georgezhang@vmware.com>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pv-drivers@vmware.com
Subject: Re: [PATCH 01/12] VMCI: context implementation.
Date: Mon, 29 Oct 2012 19:07:52 -0700 [thread overview]
Message-ID: <20121030020752.GA1920@kroah.com> (raw)
In-Reply-To: <20121030010333.17788.94988.stgit@promb-2n-dhcp175.eng.vmware.com>
On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote:
> VMCI Context code maintains state for vmci and allows the driver to communicate with multiple VMs.
>
Very minor nit, wrap your changelog comments at 72 columns or at the
least, 80. Didn't checkpatch complain about that?
> +/*
> + * vmci_context_id_to_host_vmid() - Map CID to HostID
> + * @context_id: Context ID of VMCI context.
> + * @host_vmid: Host VM ID data
> + * @host_vmid_len: Length of Host VM ID Data.
> + *
> + * Maps a context ID to the host specific (process/world) ID
> + * of the VM/VMX. This function is not used on Linux systems
> + * and should be ignored.
> + */
> +int vmci_context_id_to_host_vmid(u32 context_id,
> + void *host_vmid, size_t host_vmid_len)
> +{
> + return VMCI_ERROR_UNAVAILABLE;
> +}
> +EXPORT_SYMBOL_GPL(vmci_context_id_to_host_vmid);
Why even have this function if it doesn't do anything?
thanks,
greg k-h
next prev parent reply other threads:[~2012-10-30 2:06 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 1:03 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-10-30 1:03 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-10-30 2:07 ` Greg KH [this message]
2012-10-30 2:10 ` Greg KH
2012-10-30 4:01 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:46 ` Greg KH
2012-10-30 15:56 ` Dmitry Torokhov
2012-10-30 1:03 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-10-30 1:04 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2012-10-30 1:04 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2012-10-30 2:21 ` Greg KH
2012-10-30 2:23 ` Greg KH
2012-10-30 4:15 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:49 ` Greg KH
2012-10-30 1:04 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2012-10-30 2:24 ` Greg KH
2012-10-30 4:58 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:50 ` Greg KH
2012-10-30 2:26 ` Greg KH
2012-10-30 5:01 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:50 ` Greg KH
2012-10-30 15:59 ` Dmitry Torokhov
2012-10-30 1:04 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2012-10-30 1:04 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-10-30 1:04 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2012-10-30 2:29 ` Greg KH
2012-10-30 5:20 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:51 ` Greg KH
2012-10-30 16:11 ` Dmitry Torokhov
2012-10-30 2:29 ` Greg KH
2012-10-30 5:21 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 1:05 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2012-10-30 1:05 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2012-10-30 1:05 ` [PATCH 11/12] VMCI: host " George Zhang
2012-10-30 1:05 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-10-30 2:32 ` Greg KH
2012-10-30 5:22 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 2:38 ` Greg KH
2012-10-30 2:19 ` [PATCH 00/12] VMCI for Linux upstreaming Greg KH
2012-10-30 4:07 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:48 ` Greg KH
2012-10-30 16:18 ` Dmitry Torokhov
2012-10-30 16:27 ` Greg KH
2012-10-30 19:43 ` Dmitry Torokhov
2012-10-30 19:59 ` Greg KH
2012-11-01 17:28 George Zhang
2012-11-01 17:28 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-07 18:40 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-07 18:41 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-21 20:31 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-21 20:31 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-21 21:04 ` Joe Perches
2013-01-08 23:52 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2013-01-08 23:52 ` [PATCH 01/12] VMCI: context implementation George Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030020752.GA1920@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgezhang@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome