From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965280Ab2J3SWV (ORCPT ); Tue, 30 Oct 2012 14:22:21 -0400 Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:25767 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759673Ab2J3SWT (ORCPT ); Tue, 30 Oct 2012 14:22:19 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/EjIB0nMJBT7sSYJcu6pHV Date: Tue, 30 Oct 2012 11:22:16 -0700 From: Tony Lindgren To: Pantelis Antoniou Cc: Paul Walmsley , Russell King , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Koen Kooi , Matt Porter , Russ Dill Subject: Re: [PATCH] omap: Export various omap_hwmod related functions Message-ID: <20121030182215.GN11908@atomide.com> References: <1351699014-4259-1-git-send-email-panto@antoniou-consulting.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1351699014-4259-1-git-send-email-panto@antoniou-consulting.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pantelis Antoniou [121030 11:05]: > omap_hwmod_lookup / omap_device_build / omap_device_build_ss; > these functions can be used just fine by modules, there's no need not > to have them exported. Just curious, where do you plan to use these? These will be private to arch/arm/mach-omap2 and won't be available to drivers with the patches we have queued up in omap-for-v3.8/cleanup-headers branch. Regards, Tony > Signed-off-by: Pantelis Antoniou > --- > arch/arm/mach-omap2/omap_hwmod.c | 2 ++ > arch/arm/plat-omap/omap_device.c | 6 ++++-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c > index b969ab1..5b8b6ec 100644 > --- a/arch/arm/mach-omap2/omap_hwmod.c > +++ b/arch/arm/mach-omap2/omap_hwmod.c > @@ -138,6 +138,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -3041,6 +3042,7 @@ struct omap_hwmod *omap_hwmod_lookup(const char *name) > > return oh; > } > +EXPORT_SYMBOL(omap_hwmod_lookup); > > /** > * omap_hwmod_for_each - call function for each registered omap_hwmod > diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c > index 7a7d1f2..a15b715 100644 > --- a/arch/arm/plat-omap/omap_device.c > +++ b/arch/arm/plat-omap/omap_device.c > @@ -663,7 +663,7 @@ void omap_device_delete(struct omap_device *od) > * information. Returns ERR_PTR(-EINVAL) if @oh is NULL; otherwise, > * passes along the return value of omap_device_build_ss(). > */ > -struct platform_device __init *omap_device_build(const char *pdev_name, int pdev_id, > +struct platform_device *omap_device_build(const char *pdev_name, int pdev_id, > struct omap_hwmod *oh, void *pdata, > int pdata_len, > struct omap_device_pm_latency *pm_lats, > @@ -678,6 +678,7 @@ struct platform_device __init *omap_device_build(const char *pdev_name, int pdev > pdata_len, pm_lats, pm_lats_cnt, > is_early_device); > } > +EXPORT_SYMBOL(omap_device_build); > > /** > * omap_device_build_ss - build and register an omap_device with multiple hwmods > @@ -696,7 +697,7 @@ struct platform_device __init *omap_device_build(const char *pdev_name, int pdev > * platform_device record. Returns an ERR_PTR() on error, or passes > * along the return value of omap_device_register(). > */ > -struct platform_device __init *omap_device_build_ss(const char *pdev_name, int pdev_id, > +struct platform_device *omap_device_build_ss(const char *pdev_name, int pdev_id, > struct omap_hwmod **ohs, int oh_cnt, > void *pdata, int pdata_len, > struct omap_device_pm_latency *pm_lats, > @@ -751,6 +752,7 @@ odbs_exit: > > return ERR_PTR(ret); > } > +EXPORT_SYMBOL(omap_device_build_ss); > > /** > * omap_early_device_register - register an omap_device as an early platform > -- > 1.7.12 >