From: Sam Ravnborg <sam@ravnborg.org>
To: James Hogan <james@albanarts.com>
Cc: Mike Frysinger <vapier@gentoo.org>, Michal Marek <mmarek@suse.cz>,
uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: add symbol prefix arg to kallsyms
Date: Thu, 1 Nov 2012 21:29:02 +0100 [thread overview]
Message-ID: <20121101202902.GA6439@merkur.ravnborg.org> (raw)
In-Reply-To: <20120906211125.GB4785@balrog.le.imgtec.org>
On Thu, Sep 06, 2012 at 10:11:25PM +0100, James Hogan wrote:
> Commit 1f2bfbd00e466ff3489b2ca5cc75b1cccd14c123 ("kbuild: link of
> vmlinux moved to a script") introduced in v3.5-rc1 broke kallsyms on
> architectures which have symbol prefixes.
>
> The --symbol-prefix argument used to be added to the KALLSYMS command
> line from the architecture Makefile, however this isn't picked up by the
> new scripts/link-vmlinux.sh. This resulted in symbols like
> kallsyms_addresses being added which weren't correctly overriding the
> weak symbols such as _kallsyms_addresses. These could then trigger
> BUG_ONs in kallsyms code.
>
> This is fixed by removing the KALLSYMS addition from the architecture
> Makefile, and using CONFIG_SYMBOL_PREFIX in the link-vmlinux.sh script
> to determine whether to add the --symbol-prefix argument.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
prev parent reply other threads:[~2012-11-01 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 21:11 James Hogan
2012-09-07 9:16 ` Bob Liu
2012-11-01 20:29 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101202902.GA6439@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=james@albanarts.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®