From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, joro@8bytes.org,
Suresh Siddha <suresh.b.siddha@intel.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 00/19 v3] Improve IRQ remapping abstraction in x86 core code
Date: Thu, 1 Nov 2012 22:37:26 +0100 [thread overview]
Message-ID: <20121101213726.GC31453@breakpoint.cc> (raw)
In-Reply-To: <1348656291-10375-1-git-send-email-joerg.roedel@amd.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Wed, Sep 26, 2012 at 12:44:32PM +0200, Joerg Roedel wrote:
> Hi,
Hi Jörg,
> here is the third version of the patch-set to improve the abstraction
> of interrupt remapping in the x86 core code. A more detailed description
I went through the whole series and looks good. The patches
- - x86, io_apic: Introduce x86_io_apic_ops.disable()
- - x86, io_apic: Introduce x86_io_apic_ops.print_entries for debugging
- - x86, msi: Use IRQ remapping specific setup_msi_irqs routine
- - x86, io_apic: Convert setup_ioapic_entry to function pointerx86, io_apic:
- - x86, io_apic: Move irq_remapping_enabled checks out of check_timer()
- - x86, io-apic: Move CONFIG_IRQ_REMAP code out of x86 core
trigger some checkpatch warnings, mostly the 80char thingy. I don't care about
the "quoted string split across lines" warning.
Besides the minor thingy I just mentioned,
Acked-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Sebastian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJQkuuWAAoJEHuW6BYqjPXRnVwP/08DxdazUY4SOPIvBK4+gZh7
3VW5EdTLjBSYnaWEFccwhaqqq6FgJ5MfJ862sSXUpejjApDFQdOQPlZmIwfY5lFh
n3z20/6Nvum6mCvZLUEi7D+cQZ42ZWfyQW62dBxwQvw6sex884f5DUFqftlCUJzA
qlCBXoqVRkW03stfH8j4rDI+lponuR6P1m7hdV4r7CB95RthME/ZOpHQ3G2qSTRF
7mCRJ6eP7eLdZSichWHuhyXcil1uADglPw8m9PKtEE7AW9satiXO/b/pEFiDDdNr
xcb7Sc3OalccYVe7/Hs5WypNg05e/N4WHuTx4Y4gD2f6pHJA64bbZ6+3nmMJBt9y
NbCzuDg1dgXFG0YQkPCbULGSnu/Z6DKnryrPvmRhCQUS7w8pXMOfhdKz8q2v+l8G
riej/ZGHCGbf0UmvM+HguTjuTTCGMdvkCRGpx/UwVvy8Ll5sb0o73ORw25hdPHdD
VGaximc4jmRBTSMB7ncOCMYOjTp6CKhG2ZvtA6q+JDS+GGTv3tfEBHri2STzZ7BY
SrG8boABWJq39xxsivltimMJFa9IBCWpTyb/yG7T4I4ypOwI2QSdRob/Rs/BprHI
SdzYlj2BFiR3ToF8WDXrMw9ywkVG6QL1oVrUDA+LHaBZO574KW/LMMuktYCj+gmY
mQEcW6k8kS39uBtiL0Kh
=tIW6
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2012-11-01 21:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 10:44 Joerg Roedel
2012-09-26 10:44 ` [PATCH 01/19] x86, apic: Move irq_remapping_enabled checks into IRQ-remapping code Joerg Roedel
2012-09-26 10:44 ` [PATCH 02/19] x86, apic: Mask IO-APIC and PIC unconditionally on LAPIC resume Joerg Roedel
2012-09-26 10:44 ` [PATCH 03/19] x86, io_apic: Introduce x86_io_apic_ops.disable() Joerg Roedel
2012-09-26 10:44 ` [PATCH 04/19] x86, io_apic: Introduce x86_io_apic_ops.print_entries for debugging Joerg Roedel
2012-09-26 10:44 ` [PATCH 05/19] x86, hpet: Introduce x86_msi_ops.setup_hpet_msi Joerg Roedel
2012-09-26 10:44 ` [PATCH 06/19] x86, msi: Use IRQ remapping specific setup_msi_irqs routine Joerg Roedel
2012-09-26 10:44 ` [PATCH 07/19] x86, io_apic: Introduce set_affinity function pointer Joerg Roedel
2012-09-26 10:44 ` [PATCH 08/19] x86, io_apic: Convert setup_ioapic_entry to " Joerg Roedel
2012-09-26 10:44 ` [PATCH 09/19] x86, io_apic: Move irq_remapping_enabled checks out of check_timer() Joerg Roedel
2012-09-26 10:44 ` [PATCH 10/19] x86, io_apic: Remove irq_remapping_enabled check in setup_timer_IRQ0_pin Joerg Roedel
2012-09-26 10:44 ` [PATCH 11/19] x86, irq: Move irq_remapping_enabled declaration to iommu code Joerg Roedel
2012-09-26 10:44 ` [PATCH 12/19] x86, irq: Add data structure to keep AMD specific irq remapping information Joerg Roedel
2012-09-26 10:44 ` [PATCH 13/19] x86, io-apic: Move CONFIG_IRQ_REMAP code out of x86 core Joerg Roedel
2012-09-26 10:44 ` [PATCH 14/19] x86, io-apic: Remove !irq_remapped() check from __target_IO_APIC_irq() Joerg Roedel
2012-09-26 10:44 ` [PATCH 15/19] x86, irq: Move irq_remapped() check into free_remapped_irq Joerg Roedel
2012-09-26 10:44 ` [PATCH 16/19] x86, irq: Introduce setup_remapped_irq() Joerg Roedel
2012-09-26 10:44 ` [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back Joerg Roedel
2012-09-26 10:44 ` [PATCH 18/19] x86, io_apic: Introduce eoi_ioapic_pin call-back Joerg Roedel
2012-09-26 10:44 ` [PATCH 19/19] x86, irq: Move irq_remapped out of x86 core code Joerg Roedel
2012-11-01 21:37 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101213726.GC31453@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=joerg.roedel@amd.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome