From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754531Ab2KEQqh (ORCPT ); Mon, 5 Nov 2012 11:46:37 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47611 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060Ab2KEQqf (ORCPT ); Mon, 5 Nov 2012 11:46:35 -0500 Date: Mon, 05 Nov 2012 11:46:33 -0500 (EST) Message-Id: <20121105.114633.1342071685669147321.davem@davemloft.net> To: lee.jones@linaro.org Cc: pebolle@tiscali.nl, linux-kernel@vger.kernel.org, isdn@linux-pingi.de, netdev@vger.kernel.org Subject: Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning From: David Miller In-Reply-To: <20121105084419.GC2699@gmail.com> References: <20121104105332.GC27124@gmail.com> <20121104.123013.700345271120279281.davem@davemloft.net> <20121105084419.GC2699@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id qA5GkfvO009679 From: Lee Jones Date: Mon, 5 Nov 2012 09:44:19 +0100 > On Sun, 04 Nov 2012, David Miller wrote: > >> From: Lee Jones >> Date: Sun, 4 Nov 2012 11:53:32 +0100 >> >> > On Sun, 04 Nov 2012, Paul Bolle wrote: >> > >> >> On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: >> >> > On Sat, 03 Nov 2012, Paul Bolle wrote: >> >> > > On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: >> >> > > > This patch fixes: >> >> > > > drivers/isdn/i4l/isdn_common.c: In function isdn_ioctl: >> >> > > > drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable s [-Wunused-variable] >> >> > > >> >> > > Did you have CONFIG_NETDEVICES not set in this build? >> >> > >> >> > Ah yes, I see it. The function went down further than I thought >> >> > it did. So the real fix is to ensure 's' is defined inside of >> >> > some ifdef CONFIG_NETDEVICES guards. >> >> >> >> What puzzles me is that we only find these "#ifdef CONFIG_NETDEVICES" >> >> guards in this file and not in isdn_net.c, were all the ioctl commands >> >> guarded that way seem to be calling into. On first glance that doesn't >> >> make much sense. >> >> >> >> (Actually the idea of having ISDN without NETDEVICES is a bit puzzling >> >> too. But there are too many parts of the isdn subsystem that I'm >> >> unfamiliar with to say whether that can make sense.) >> > >> > I'm in the same position as you Paul. I just noticed the warning so >> > fixed it following the current way of doing things. Any, more >> > substantial changes requiring greater knowledge of the subsystem >> > would have to be done by someone else. >> >> I think the most appropriate thing to do is make CONFIG_ISDN depend >> upon CONFIG_NETDEVICES in the Kconfig file. > > ... and then remove the CONFIG_NETDEVICES guards in isdn_common.c? > > If that's suitable more suitable I can do that instead? > > Just need a yay or nay and I'll make it happen. "yay" {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I