From: Thierry Reding <thierry.reding@avionic-design.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org
Subject: SPARC and OF_GPIO
Date: Mon, 5 Nov 2012 10:53:15 +0100 [thread overview]
Message-ID: <20121105095315.GG5847@avionic-0098.mockup.avionic-design.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
[resending with David's correct email address]
Hi David,
There have been a number of reports that Linux kernel builds fail on
SPARC because it doesn't support OF_GPIO, which provides the of_node
field of the struct gpio_chip.
One of the drivers I wrote (gpio-adnp) accesses this unconditionally but
only depends on OF and not OF_GPIO, so it fails to build on SPARC. A
similar problem happens with the gpio-fan driver, which defines the OF
match table only if OF_GPIO is selected, but uses it even if only OF but
not OF_GPIO is selected.
While it is clearly the drivers which are at fault here it still raises
the question as to why SPARC still conflicts with OF_GPIO. Over two
years ago, commit 5ab5fc7 made most of the OF symbols available to all
platforms except SPARC. The commit message explicitly states that this
should probably be re-evaluated.
Are you aware of any reasons why this conflict would still be necessary?
This is not only the case for OF_GPIO but likely also for OF_SPI,
OF_I2C, OF_IRQ and OF_ADDRESS. Shouldn't those all work even on SPARC
nowadays?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2012-11-05 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 9:53 Thierry Reding [this message]
2012-11-06 23:40 ` David Miller
2012-11-07 6:52 ` Thierry Reding
2012-11-07 7:34 ` David Miller
2012-11-30 9:35 ` Grant Likely
2012-11-30 9:40 ` Thierry Reding
2012-11-30 9:58 ` Grant Likely
2012-11-30 16:46 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-11-05 9:22 Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105095315.GG5847@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome