From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, jolsa@redhat.com, namhyung.kim@lge.com
Subject: Re: [PATCH v2 03/16] perf, core: Add a concept of a weightened sample
Date: Mon, 5 Nov 2012 14:51:01 -0800 [thread overview]
Message-ID: <20121105225101.GB25167@tassilo.jf.intel.com> (raw)
In-Reply-To: <20121105200147.GB7962@infradead.org>
> > +
> > if (sample_type & PERF_SAMPLE_READ)
> > size += event->read_size;
> >
> > @@ -4080,6 +4083,9 @@ void perf_output_sample(struct perf_output_handle *handle,
> > if (sample_type & PERF_SAMPLE_PERIOD)
> > perf_output_put(handle, data->period);
> >
> > + if (sample_type & PERF_SAMPLE_WEIGHT)
> > + perf_output_put(handle, data->weight);
> > +
>
> Yeap, it should go after PERF_SAMPLE_STACK_USER
There was a bug I recently noticed but haven't investigated so far.
When I do -b -W --transaction the flags/weights get corrupted.
May be related to that.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-11-05 22:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 13:50 [PATCH v2 00/16] perf: add memory access sampling support Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 01/16] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 02/16] perf/x86: add flags to event constraints Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 03/16] perf, core: Add a concept of a weightened sample Stephane Eranian
2012-11-05 20:01 ` Arnaldo Carvalho de Melo
2012-11-05 20:07 ` Arnaldo Carvalho de Melo
2012-11-05 22:51 ` Andi Kleen [this message]
2012-11-05 13:50 ` [PATCH v2 04/16] perf: add minimal support for PERF_SAMPLE_WEIGHT Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 05/16] perf, tools: Add arbitary aliases and support names with - Stephane Eranian
2012-11-14 7:34 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2012-11-05 13:50 ` [PATCH v2 06/16] perf: add support for PERF_SAMPLE_ADDR in dump_sampple() Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 07/16] perf: add generic memory sampling interface Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 08/16] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2012-11-06 13:31 ` Andi Kleen
2012-11-06 14:29 ` Stephane Eranian
2012-11-06 18:50 ` Andi Kleen
2012-11-06 19:37 ` Stephane Eranian
2012-11-07 14:39 ` Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 09/16] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 10/16] perf/x86: add support for PEBS Precise Store Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 11/16] perf tools: add mem access sampling core support Stephane Eranian
2012-11-05 13:50 ` [PATCH v2 12/16] perf report: add support for mem access profiling Stephane Eranian
2012-11-05 13:51 ` [PATCH v2 13/16] perf record: " Stephane Eranian
2012-11-05 13:51 ` [PATCH v2 14/16] perf tools: add new mem command for memory " Stephane Eranian
2012-11-06 15:44 ` Arnaldo Carvalho de Melo
2012-11-06 15:49 ` Stephane Eranian
2012-11-06 16:51 ` Arnaldo Carvalho de Melo
2012-11-06 17:05 ` Arnaldo Carvalho de Melo
2012-11-06 15:50 ` Arnaldo Carvalho de Melo
2012-11-06 15:57 ` Stephane Eranian
2012-11-06 17:07 ` Arnaldo Carvalho de Melo
2012-11-05 13:51 ` [PATCH v2 15/16] perf: add PERF_RECORD_MISC_MMAP_DATA to RECORD_MMAP Stephane Eranian
2012-11-05 13:51 ` [PATCH v2 16/16] perf tools: detect data vs. text mappings Stephane Eranian
2012-11-06 20:52 ` [PATCH v2 00/16] perf: add memory access sampling support Arnaldo Carvalho de Melo
2012-11-07 7:38 ` Namhyung Kim
2012-11-07 10:02 ` Stephane Eranian
2012-11-07 14:53 ` Masami Hiramatsu
2012-11-07 14:56 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105225101.GB25167@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®