mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dave Jones <davej@redhat.com>
Cc: Hugh Dickins <hughd@google.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Sasha Levin <levinsasha928@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	florianSchandinat@gmx.de
Subject: Re: tty, vt: lockdep warnings
Date: Tue, 6 Nov 2012 17:38:45 +0000	[thread overview]
Message-ID: <20121106173845.4a50d661@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20121106164214.GA18246@redhat.com>

>  > The root
>  > cause is loading two different framebuffers with one taking over from
>  > another - that should be an obscure corner case and once the fuzz testing
>  > can avoid.
>  > 
>  > I had a semi-informed poke at this and came up with a possible patch (not very tested)
> 
> If this fixes the real problems we've been seeing, I'll dance a jig.

Youtube...

At this point my bigger concern is that it'll just make something else
warn instead. The underlying problem is that fbcon layer implements a
single threaded notifier whose locking semantics are at best random. It's
not calld with a specific set of locks each time. Possibly it sohuld be
two notifiers (one for fb stuff, one for console layer stuff) but the
entire layer is horrible. I live in home the KMS guys will rip out the
useful bits and build a straight kms fb layer with refcounting and the
like 8)

Testing certainly needed and if it's still blowing up then hopefully
further traces will help fix up the other cases we don't know about.

Alan

  reply	other threads:[~2012-11-06 17:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 19:37 Sasha Levin
2012-10-26 13:37 ` Alan Cox
2012-11-05 17:26   ` Sasha Levin
2012-11-05 17:59     ` Alan Cox
2012-11-05 18:00       ` Sasha Levin
2012-11-05 19:17         ` Hugh Dickins
2012-11-05 20:15           ` Alan Cox
2012-11-05 20:34             ` Hugh Dickins
2012-11-06 16:11               ` Alan Cox
2012-11-06 16:42                 ` Dave Jones
2012-11-06 17:38                   ` Alan Cox [this message]
2012-11-07 13:47                     ` Sasha Levin
2012-11-07 16:02                       ` Alan Cox
2012-11-07 16:15                         ` Bjørn Mork
2012-11-07 17:01                           ` Alan Cox
2012-11-08 14:34                           ` tty, vt: lockdep warnings (Patch v3) Alan Cox
2012-11-09 19:34                             ` Hugh Dickins
2012-11-09 19:42                               ` Sasha Levin
2012-11-13 16:24                                 ` Sasha Levin
2012-11-07  4:29                 ` tty, vt: lockdep warnings Hugh Dickins
2012-11-07  6:26                   ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121106173845.4a50d661@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=davej@redhat.com \
    --cc=florianSchandinat@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hughd@google.com \
    --cc=jslaby@suse.cz \
    --cc=levinsasha928@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®