mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Chris J Arges <chris.j.arges@canonical.com>
Cc: Steve French <sfrench@samba.org>,
	linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH cifs-next] fs: cifs: make smb_echo_interval tunable
Date: Fri, 9 Nov 2012 10:55:21 -0500	[thread overview]
Message-ID: <20121109105521.00f3c291@tlielax.poochiereds.net> (raw)
In-Reply-To: <509D23F5.3080107@canonical.com>

On Fri, 09 Nov 2012 09:40:37 -0600
Chris J Arges <chris.j.arges@canonical.com> wrote:

> > 
> > I'm not so sure I like making this tunable...
> > 
> Ok, I saw the 'FIXME: tunable?', and thought this was something that
> could be exposed as a parameter in the future.
> 

Yeah, when I originally wrote that code I put that comment in. Since
then I think we've figured out more about how the echo facility in CIFS
should work. Making it tunable is not really a great solution. Having
the echoes better adapt to the situation would be preferable.

-- 
Jeff Layton <jlayton@redhat.com>

      reply	other threads:[~2012-11-09 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08 20:50 Chris J Arges
2012-11-09 11:00 ` Jeff Layton
2012-11-09 15:40   ` Chris J Arges
2012-11-09 15:55     ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121109105521.00f3c291@tlielax.poochiereds.net \
    --to=jlayton@redhat.com \
    --cc=chris.j.arges@canonical.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®