From: Thierry Reding <thierry.reding@avionic-design.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: Shiraz Hashim <shiraz.hashim@st.com>,
Viresh Kumar <viresh.kumar@linaro.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: spear: Staticize spear_pwm_config()
Date: Fri, 9 Nov 2012 12:58:33 +0100 [thread overview]
Message-ID: <20121109115833.GA22618@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1352461942.9150.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On Fri, Nov 09, 2012 at 07:52:22PM +0800, Axel Lin wrote:
> spear_pwm_config() is not referenced outside of this file, make it static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-spear.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 6a8fd9b..83b21d9 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -76,8 +76,8 @@ static inline void spear_pwm_writel(struct spear_pwm_chip *chip,
> writel_relaxed(val, chip->mmio_base + (num << 4) + offset);
> }
>
> -int spear_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, int duty_ns,
> - int period_ns)
> +static int spear_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
> + int duty_ns, int period_ns)
> {
> struct spear_pwm_chip *pc = to_spear_pwm_chip(chip);
> u64 val, div, clk_rate;
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-09 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 11:52 Axel Lin
2012-11-09 11:53 ` Viresh Kumar
2012-11-09 11:58 ` Thierry Reding [this message]
2012-11-09 11:59 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121109115833.GA22618@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=axel.lin@ingics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shiraz.hashim@st.com \
--cc=viresh.kumar@linaro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®